Skip to content

fix button on public upload page for mobile - #1897

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-public-button
Oct 25, 2016
Merged

fix button on public upload page for mobile#1897
MorrisJobke merged 1 commit into
masterfrom
fix-public-button

Conversation

@jancborchardt

Copy link
Copy Markdown
Member

Before & after:
capture du 2016-10-24 23-28-19capture du 2016-10-24 23-27-21

Please review @nextcloud/designers @xMartin

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardtjancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: sharing labels Oct 24, 2016
@jancborchardtjancborchardt added this to the Nextcloud 11.0 milestone Oct 24, 2016
@mention-bot

Copy link
Copy Markdown

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @MorrisJobke and @oparoz to be potential reviewers.

@rullzer

Copy link
Copy Markdown
Member

👍

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

@MorrisJobke

Copy link
Copy Markdown
Member

CI had hiccups - it passed in the push job -> merge

@MorrisJobke
MorrisJobke merged commit e8c359d into masterOct 25, 2016
@MorrisJobke
MorrisJobke deleted the fix-public-button branch October 25, 2016 09:03
@jancborchardt

Copy link
Copy Markdown
MemberAuthor

Btw, this really seems like a bugfix we should backport (@rullzer do you agree? ;)

@jancborchardt

Copy link
Copy Markdown
MemberAuthor

Backports at #2056 and #2057

@MorrisJobke

Copy link
Copy Markdown
Member

@jancborchardt Once the backport PRs are opened please remove the "backport-request" label 😉

@jancborchardt

Copy link
Copy Markdown
MemberAuthor

@MorrisJobke right, done!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jancborchardt@mention-bot@rullzer@MorrisJobke