Uh oh!
There was an error while loading. Please reload this page.
Exclude groups from sharing: Skip delete groups - #19124
Merged
Merged
Conversation
kesselbforce-pushed
the
bug/13647/ignore-delete-groups
branch
from
February 21, 2020 22:22
4736e72 to
fc006d2Comparekesselbforce-pushed
the
bug/13647/ignore-delete-groups
branch
from
April 23, 2020 18:51
fc006d2 to
3917daeCompareblizzz
approved these changes
Apr 24, 2020
blizzz
left a comment
Member
There was a problem hiding this comment.
indentation seems off in the js file
kesselbforce-pushed
the
bug/13647/ignore-delete-groups
branch
2 times, most recently
from
April 24, 2020 16:03
576d828 to
8772a1eCompareSigned-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
bug/13647/ignore-delete-groups
branch
from
April 24, 2020 16:10
8772a1e to
16f29d8Comparekesselb
commented
Apr 24, 2020
ContributorAuthor
|
MorrisJobke
commented
May 4, 2020
Member
/backport to stable18 |
MorrisJobke
commented
May 4, 2020
Member
/backport to stable17 |
This was referenced May 4, 2020
kesselb
commented
May 4, 2020
ContributorAuthor
Hmm. It seems I lost fc006d2 on rebase 🙈 |
MorrisJobke
commented
May 4, 2020
Member
New PR :) But I tested and the UI and all still worked. On the next save it will not bet there as well. So this is basically only a cleanup thing. |
kesselb
commented
May 4, 2020
ContributorAuthor
Exactly. I will have a look later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#13647
server/apps/settings/js/settings.js
Lines 58 to 60 in 0a24094
results.findwill return undefined if no group found hencedisplaynamefail. I don't know what's wrong with the indention. ESLint does not complain locally about the changes but the rest of the file seems to be wrong.