Uh oh!
There was an error while loading. Please reload this page.
Check for empty authorization headers for office requests - #19180
Merged
Conversation
icewind1991
approved these changes
Jan 28, 2020
…nonymous option on the whole tree Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/office-anonymous-empty-auth
branch
from
February 4, 2020 14:35
f5e3d56 to
8fba05dComparejuliusknorr
commented
Feb 4, 2020
MemberAuthor
Tests should also be happy now. |
rullzer
reviewed
Feb 5, 2020
| } | ||
| public function testAnonymousHead() { | ||
| $response = $this->sendRequest('HEAD', '', 'Microsoft Office does strange things'); |
rullzer
approved these changes
Feb 5, 2020
juliusknorr
commented
Apr 3, 2020
MemberAuthor
/backport to stable18 |
juliusknorr
commented
Apr 3, 2020
MemberAuthor
/backport to stable17 |
backport to stable18 in #20282 |
backport to stable17 in #20283 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently some office versions do also sent an request without an authorization header or with
Authorization: Bearerand expect the request to return a successful status for their HEAD request. The OPTIONS request is also not only performed on the root folder but the parent one.This should fix opening Office files from a mounted webdav drive in Windows without requesting the credentials again.
Follow up to #16739