Skip to content

Center Buttons - #19238

Merged
skjnldsv merged 2 commits into
nextcloud:masterfrom
MarcMichalsky:patch-1
Feb 3, 2020
Merged

Center Buttons#19238
skjnldsv merged 2 commits into
nextcloud:masterfrom
MarcMichalsky:patch-1

Conversation

@MarcMichalsky

@MarcMichalskyMarcMichalsky commented Jan 31, 2020

Copy link
Copy Markdown
Contributor

Since Version 18.0.0 the Registration button of the registration app is not centered anymore.

@MarcMichalsky
Center Buttons
9f473f7
Since Version 18.0.0 the Registration button of the [registration app](https://github.com/pellaeon/registration) is not centered anymore.
@georgehrke

georgehrke commented Jan 31, 2020

Copy link
Copy Markdown
Member

@MarcMichalsky Can you please provide before / after screenshots? Thx

Did you test whether your change affects other alternative logins?

@georgehrkegeorgehrke added the 3. to review Waiting for reviews label Jan 31, 2020
@kesselb

kesselb commented Jan 31, 2020

Copy link
Copy Markdown
Contributor

Should fix #19049

@kesselbkesselb mentioned this pull request Jan 31, 2020
Closed
Dennis1993
Dennis1993 approved these changes Jan 31, 2020
View reviewed changes

@Dennis1993Dennis1993 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me on NC 18.0.0 on desktop and mobile!

MarcMichalsky
MarcMichalsky commented Jan 31, 2020
View reviewed changes

@MarcMichalskyMarcMichalsky left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the changes on my site. It works well and I didn't spot any disturbance with other buttons.

before
after

@kesselbkesselb added the bug label Feb 1, 2020
@kesselbkesselb added this to the Nextcloud 19 milestone Feb 1, 2020
skjnldsv
skjnldsv approved these changes Feb 3, 2020
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and make sense

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 3, 2020
@skjnldsv
skjnldsv merged commit 4c9cc5f into nextcloud:masterFeb 3, 2020
@welcome

welcomeBot commented Feb 3, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@skjnldsv

skjnldsv commented Feb 3, 2020

Copy link
Copy Markdown
Member

/backport to stable18

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 3, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 3, 2020

Copy link
Copy Markdown

backport to stable18 in #19271

@MarcMichalsky
MarcMichalsky deleted the patch-1 branch February 3, 2020 09:27
This was referenced Feb 4, 2020
Closed
Closed
@hensephil

hensephil commented Feb 4, 2020

Copy link
Copy Markdown

Can you please show me the whole css config. Because it doesn't work for me.

This was referenced Feb 7, 2020
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dennis1993Dennis1993Dennis1993 approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

7 participants

@MarcMichalsky@georgehrke@kesselb@skjnldsv@hensephil@Dennis1993@juliusknorr