Uh oh!
There was an error while loading. Please reload this page.
Use 2 chars on placeholder in old jquery avatars - #19405
Closed
matchish wants to merge 1 commit into
Closed
Conversation
Uh oh!
There was an error while loading. Please reload this page.
gary-kim
commented
Feb 14, 2020
Member
@matchish Could you rebase your branch? |
skjnldsv
left a comment
Member
There was a problem hiding this comment.
code looks ok, will review live after rebase
matchish
commented
Feb 24, 2020
ContributorAuthor
Sorry forgot to rebase. I'll do it tomorrow |
nextcloud#19335 Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
matchishforce-pushed
the
legacy-avatar-placeholder
branch
from
February 25, 2020 06:15
34ca225 to
a695851Comparematchish
commented
Feb 25, 2020
ContributorAuthor
@skjnldsv Rebased |
Member
/compile amend / EDIT: 😕 |
skjnldsv
commented
Feb 26, 2020
Member
@gary-kim I guess this is because it's a fork |
skjnldsv
commented
Feb 26, 2020
Member
/compile amend / |
jancborchardt
requested review from
ChristophWurst, gary-kim, nickvergessen and skjnldsvApril 23, 2020 08:36
skjnldsv
approved these changes
Apr 23, 2020
skjnldsv
commented
Apr 23, 2020
Member
Please rebase :) |
gary-kim
approved these changes
Apr 23, 2020
ChristophWurst
commented
Apr 24, 2020
Member
I couldn't push to the forked remote, so I created a new PR at #20634 with the rebased & rebuilt version. |
rullzer
commented
Apr 30, 2020
Member
Done in #20634 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#19335
Signed-off-by: Sergey Shliakhov husband.sergey@gmail.com