Uh oh!
There was an error while loading. Please reload this page.
Reduce flow logging at INFO level, move to DEBUG - #19477
Merged
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
ChristophWurst, blizzz, nickvergessen and rullzerFebruary 14, 2020 11:03
rullzer
approved these changes
Feb 14, 2020
ChristophWurst
approved these changes
Feb 14, 2020
nickvergessen
approved these changes
Feb 14, 2020
blizzz
approved these changes
Feb 14, 2020
blizzz
commented
Feb 14, 2020
Member
/backport to stable18 |
backport to stable18 in #19481 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current flow log file is quite verbose, so moving those log entries to debug should make sure we only have important entries in there.
@blizzz Maybe we should also not have the log enabled by default?
To reproduce, create a file access control rule and see your log grow to multiple MB in minutes.