Skip to content

Change the route generation of AuthPublicShareController.php - #19478

Merged
rullzer merged 2 commits into
nextcloud:masterfrom
Tim-Obert:bug/19475/fix-routes-generation-authpublicsharecontroller
Feb 23, 2020
Merged

Change the route generation of AuthPublicShareController.php#19478
rullzer merged 2 commits into
nextcloud:masterfrom
Tim-Obert:bug/19475/fix-routes-generation-authpublicsharecontroller

Conversation

@Tim-Obert

@Tim-ObertTim-Obert commented Feb 14, 2020•
edited by rullzer
Loading

Copy link
Copy Markdown
Contributor

closes#19475
Signed-off-by: Tim Obert tobert@w-commerce.de

@Tim-Obert
Change the route generation of AuthPublicShareController.php and adju…
058180d
…st the routes for file sharing
Signed-off-by: Tim Obert <tobert@w-commerce.de>
@Tim-ObertTim-Obert mentioned this pull request Feb 14, 2020
Closed
nickvergessen
nickvergessen reviewed Feb 14, 2020
View reviewed changes
Comment threadlib/public/AppFramework/AuthPublicShareController.php Outdated
@gary-kimgary-kim added 3. to review Waiting for reviews bug labels Feb 14, 2020
nickvergessen
nickvergessen requested changes Feb 14, 2020
View reviewed changes
Comment threadcore/routes.php
Comment threadlib/public/AppFramework/AuthPublicShareController.php Outdated
Comment threadlib/public/AppFramework/AuthPublicShareController.php
@nickvergessennickvergessen added this to the Nextcloud 19 milestone Feb 14, 2020
@nickvergessen

nickvergessen commented Feb 14, 2020

Copy link
Copy Markdown
Member

And then use routes:

 ['name' => 'DummyThing#showShare', 'url' => '/secret/{token}', 'verb' => 'GET'],
['name' => 'DummyThing#showAuthenticate', 'url' => '/secret/{token}/authenticate/{redirect}', 'verb' => 'GET'],
['name' => 'DummyThing#authenticate', 'url' => '/secret/{token}/authenticate/{redirect}', 'verb' => 'POST'],

@Tim-Obert
Fix requested changes
4c1834d
Signed-off-by: Tim Obert <tobert@w-commerce.de>
@blizzz

blizzz commented Feb 19, 2020

Copy link
Copy Markdown
Member

cc @Rello weren't you also doing things with this Controller?

rullzer
rullzer approved these changes Feb 23, 2020
View reviewed changes
Comment threadlib/public/AppFramework/AuthPublicShareController.php
return $app . '.' . $class . '.' . $function;
$class = (new \ReflectionClass($this))->getShortName();
if ($this->appName === 'files_sharing') {
$class = strtolower($class);

@rullzerrullzerFeb 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right because we do nasty things in core.
Lets do this for now and at some poitn make sure that we fix those share routes.

@rullzer
rullzer merged commit f885cef into nextcloud:masterFeb 23, 2020
@welcome

welcomeBot commented Feb 23, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@rullzer

rullzer commented Feb 23, 2020

Copy link
Copy Markdown
Member

Good stuff thanks for all the work @Tim-Obert

@rullzer

rullzer commented Feb 23, 2020

Copy link
Copy Markdown
Member

/backport to stable18

@rullzer

rullzer commented Feb 23, 2020

Copy link
Copy Markdown
Member

/backport to stable17

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 23, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 23, 2020

Copy link
Copy Markdown

backport to stable18 in #19610

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 23, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 23, 2020

Copy link
Copy Markdown

backport to stable17 in #19611

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

AuthPublicShareController generates the wrong routes

6 participants

@Tim-Obert@nickvergessen@blizzz@rullzer@MorrisJobke@gary-kim