Skip to content

Make sure the secondary view registered for systemtags has an id - #19511

Merged
ChristophWurst merged 2 commits into
masterfrom
bugfix/noid/secondary-view-id
Feb 21, 2020
Merged

Make sure the secondary view registered for systemtags has an id#19511
ChristophWurst merged 2 commits into
masterfrom
bugfix/noid/secondary-view-id

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Feb 17, 2020

Copy link
Copy Markdown
Member

Close#18957

The secondary view registration requires its views to have an id property set

consthasDuplicate=this.#state.views.findIndex(check=>check.id===view.id)>-1

To reproduce enable the talk app and try to access the system tags in the files sidebar.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@gary-kimgary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 17, 2020
@ChristophWurst
ChristophWurst merged commit 8bbc387 into masterFeb 21, 2020
@ChristophWurst
ChristophWurst deleted the bugfix/noid/secondary-view-id branch February 21, 2020 11:18
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable18 in #19574

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: tags

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retention and Files automated tagging are enabled but can't be configured in Settings

4 participants

@juliusknorr@nickvergessen@gary-kim@ChristophWurst