Skip to content

Already enabled apps - #19514

Merged
MorrisJobke merged 2 commits into
nextcloud:masterfrom
sndrr:already-enabled-apps
Apr 27, 2020
Merged

Already enabled apps#19514
MorrisJobke merged 2 commits into
nextcloud:masterfrom
sndrr:already-enabled-apps

Conversation

@sndrr

@sndrrsndrr commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

Fixes#17789.

@sndrr
sndrrforce-pushed the already-enabled-apps branch from 2ddaa70 to 45ad021CompareFebruary 17, 2020 09:18
@gary-kimgary-kim added 3. to review Waiting for reviews bug labels Feb 17, 2020
@gary-kimgary-kim added this to the Nextcloud 19 milestone Feb 17, 2020
@sndrr
sndrrforce-pushed the already-enabled-apps branch from 45ad021 to 44cb861CompareFebruary 17, 2020 10:10
This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
@rullzerrullzer mentioned this pull request Apr 23, 2020
11 tasks
sndrr added 2 commits April 24, 2020 16:30
Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>
Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>
Signed-off-by: Sander Ruitenbeek <s.ruitenbeek@getgoing.nl>
@ChristophWurst

Copy link
Copy Markdown
Member

rebased

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 24, 2020
@MorrisJobke
MorrisJobke merged commit a64681a into nextcloud:masterApr 27, 2020
nodiscc added a commit to nodiscc/xsrv that referenced this pull request Jun 1, 2020
nodiscc added a commit to nodiscc/xsrv that referenced this pull request Jul 5, 2020
 - determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version
- use ansible local fact file to store nextcloud installed version
- use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot
- installation is now idempotent
- ensure correct/restrictive permissions are set
- nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file
- reorder setup procedure (setup apache last)
- enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration
- Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html
- reload apache instead of restarting when possible
- fix Module did not set no_log for update_password (mysql_user)
- update documentation, add screenshots
- use ansible-vault to manage secret variables by default
- templatize nextcloud domain name/install directory/full URL
- make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789
- require manual configuration of nextcloud FQDN
- update calendar app to 2.0.2
- https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html
nodiscc added a commit to nodiscc/xsrv that referenced this pull request Jul 14, 2020
 - determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version
- use ansible local fact file to store nextcloud installed version
- use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot
- installation is now idempotent
- ensure correct/restrictive permissions are set
- nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file
- reorder setup procedure (setup apache last)
- enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration
- Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html
- reload apache instead of restarting when possible
- fix Module did not set no_log for update_password (mysql_user)
- update documentation, add screenshots
- use ansible-vault to manage secret variables by default
- templatize nextcloud domain name/install directory/full URL
- make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789
- require manual configuration of nextcloud FQDN
- update calendar app to 2.0.2
- https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html
nodiscc added a commit to nodiscc/xsrv that referenced this pull request Jul 14, 2020
 - determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version
- use ansible local fact file to store nextcloud installed version
- use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot
- installation is now idempotent
- ensure correct/restrictive permissions are set
- nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file
- reorder setup procedure (setup apache last)
- enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration
- Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html
- reload apache instead of restarting when possible
- fix Module did not set no_log for update_password (mysql_user)
- update documentation, add screenshots
- use ansible-vault to manage secret variables by default
- templatize nextcloud domain name/install directory/full URL
- make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789
- require manual configuration of nextcloud FQDN
- update calendar app to 2.0.2
- https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html
nodiscc added a commit to nodiscc/xsrv that referenced this pull request Jul 14, 2020
 - determine appropriate setup procedure depending on whether nextcloud is already installed or not, installed version and current role version
- use ansible local fact file to store nextcloud installed version
- use temporary extraction directory and replace the old copy with the new one instead of unpacking directly into the documentroot
- installation is now idempotent
- ensure correct/restrictive permissions are set
- nextcloud: move apache configuration steps to separate file, add automatic virtualhost configuration for nextcloud, group previous CSP settings in vhost configuration file
- reorder setup procedure (setup apache last)
- enable additional php modules https://docs.nextcloud.com/server/16/admin_manual/installation/source_installation.html#apache-web-server-configuration
- Note: 'become' is not a valid attribute for a TaskInclude, use include - https://docs.ansible.com/ansible/latest/modules/include_module.html
- reload apache instead of restarting when possible
- fix Module did not set no_log for update_password (mysql_user)
- update documentation, add screenshots
- use ansible-vault to manage secret variables by default
- templatize nextcloud domain name/install directory/full URL
- make app enable/disable task idempotent - nextcloud/server#19514, nextcloud/server#17789
- require manual configuration of nextcloud FQDN
- update calendar app to 2.0.2
- https://docs.nextcloud.com/server/16/admin_manual/maintenance/manual_upgrade.html
- update doc
- add php-mysql requirement
- update role metadata, depends on lamp role
- upgrade nextcloud to 19.0.0, upgrade all nextcloud apps
- add fine-grained ansible tags
- upgrade: copy config.php from the old installation to the new, fix permissions
- apache: integration Unset system-wide Content-Security-Policy header since Nextcloud provides its own CSP
- add nextcloud_https_mode config variable (selfsigned/letsencrypt/none)
- add tasks to generate self-signed certificates
- automatically install applications using occ app:install command, remove app-related variables and ansible tasks
- upgrade all applications during setup
- enable APCu memcache https://docs.nextcloud.com/server/19/admin_manual/configuration_server/caching_configuration.html
- gallery app replaced with photos app
- update doc
- fix upgrade mechanism/only copy old config.pho when nextcloud_action == 'upgrade'
- remove old installation directory at the end of upgrades
note on upgrades: 'Exception: Updates between multiple major versions and downgrades are unsupported.'
note on config.php file ownership/permissions: occ has to be executed with the user that owns the file config/config.php either www-data must OWN config.php (rw group access is not enough), or we have to run occ as root - the first option is probably closer to least-privilege principle
note on data directory permissions: Your data directory is readable by other users Please change the permissions to 0770 so that the directory cannot be listed by other users. An unhandled exception has been thrown: Exception: Environment not properly prepared
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'occ app:enable appname' should make it clear that an app was already enabled

6 participants

@sndrr@ChristophWurst@georgehrke@kesselb@MorrisJobke@gary-kim