Skip to content

remove noise from detectUuid and cache results - #19549

Merged
rullzer merged 1 commit into
masterfrom
fix/19418/uuid-attr-log-flood
Feb 24, 2020
Merged

remove noise from detectUuid and cache results#19549
rullzer merged 1 commit into
masterfrom
fix/19418/uuid-attr-log-flood

Conversation

@blizzz

@blizzzblizzz commented Feb 19, 2020

Copy link
Copy Markdown
Member

fixes#19418

  • error level reduced to debug, often it is just false positives
  • result is also mem-cached now, so it is not redone too often, if left to default
  • stops further read requests when the user is invalid

@blizzz
remove noise from detectUuid and cache results
407b8fd
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 19 milestone Feb 19, 2020
@blizzzblizzz mentioned this pull request Feb 19, 2020
Closed
@blizzz

blizzz commented Feb 19, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@blizzz

blizzz commented Feb 19, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@blizzz

blizzz commented Feb 19, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

ChristophWurst
ChristophWurst approved these changes Feb 21, 2020
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 24, 2020
@rullzer
rullzer merged commit aaf1cb7 into masterFeb 24, 2020
@rullzer
rullzer deleted the fix/19418/uuid-attr-log-flood branch February 24, 2020 19:03
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 24, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 24, 2020

Copy link
Copy Markdown

backport to stable18 in #19624

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 24, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 24, 2020

Copy link
Copy Markdown

backport to stable17 in #19625

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 24, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 24, 2020

Copy link
Copy Markdown

backport to stable16 in #19626

@blizzzblizzz mentioned this pull request Mar 19, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

NC17.0.3: log flooded with "Could not autodetect the UUID attribute"

5 participants

@blizzz@ChristophWurst@juliusknorr@skjnldsv@rullzer