Uh oh!
There was an error while loading. Please reload this page.
Correctly trim long cyrillic note - #19634
Merged
Merged
Conversation
nickvergessen
commented
Feb 25, 2020
MemberAuthor
/backport to stable18 |
nickvergessen
commented
Feb 25, 2020
MemberAuthor
/backport to stable17 |
nickvergessen
commented
Feb 25, 2020
MemberAuthor
/backport to stable16 |
georgehrke
approved these changes
Feb 25, 2020
nickvergessenforce-pushed
the
bugfix/noid/long-cyrillic-note
branch
from
February 25, 2020 10:12
0828e16 to
641b098Compare| $value = mb_substr($value, 0, 254); | ||
| $query->setParameter('name', $property->name); | ||
| $query->setParameter('parameter', substr($key, 0, 254)); |
Member
There was a problem hiding this comment.
parameter is also coming straight from the ics data and should use mb_substr.
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessenforce-pushed
the
bugfix/noid/long-cyrillic-note
branch
from
February 25, 2020 10:17
641b098 to
d224ee6Comparerullzer
approved these changes
Feb 25, 2020
backport to stable18 in #19636 |
backport to stable17 in #19637 |
backport to stable16 in #19638 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a contact with http://generator.lorem-ipsum.info/_russian as note