Uh oh!
There was an error while loading. Please reload this page.
Allow non integer ids in Entity Mapper - #19659
Merged
rullzer merged 1 commit intoFeb 27, 2020
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ChristophWurst, juliusknorr, kesselb and rullzerFebruary 26, 2020 13:46
ChristophWurst
commented
Feb 26, 2020
Member
Not quite. This just allows other types of a single key. The other PR will even allow composite keys. |
juliusknorr
approved these changes
Feb 26, 2020
rullzer
deleted the
techdebt/17486/allow-non-integer-ids-in-entity-mapper
branch
February 27, 2020 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #17486