Skip to content

Revive the "send email to new users" toggle for the user form - #19664

Merged
ChristophWurst merged 1 commit into
masterfrom
feature/revive-send-welcome-email-toggle
Feb 28, 2020
Merged

Revive the "send email to new users" toggle for the user form#19664
ChristophWurst merged 1 commit into
masterfrom
feature/revive-send-welcome-email-toggle

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Feb 26, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#11172

This is the minimalist version, so we can easily backport it. Someone can later integrate this better into the new form.

Todo

  • Add back toggle in bottom left
  • Send preference to server with user data
  • Only send email when admin wishes so
  • Persist toggle value

@ChristophWurstChristophWurst added this to the Nextcloud 19 milestone Feb 26, 2020
@ChristophWurst
ChristophWurstforce-pushed the feature/revive-send-welcome-email-toggle branch from 5c09e1b to 1606636CompareFebruary 27, 2020 13:42
@ChristophWurst
ChristophWurst marked this pull request as ready for review February 27, 2020 13:42
@ChristophWurstChristophWurst self-assigned this Feb 27, 2020
@ChristophWurstChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 27, 2020
skjnldsv
skjnldsv reviewed Feb 27, 2020
View reviewed changes
Comment threadapps/settings/src/views/Users.vue Outdated
@ChristophWurst
ChristophWurstforce-pushed the feature/revive-send-welcome-email-toggle branch from 1606636 to 8ab9dafCompareFebruary 28, 2020 07:36
rullzer
rullzer requested changes Feb 28, 2020
View reviewed changes
Comment threadapps/provisioning_api/lib/Controller/UsersController.php Outdated
@ChristophWurst
Revive the "send email to new users" toggle for the user form
d47daef
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the feature/revive-send-welcome-email-toggle branch from 8ab9daf to d47daefCompareFebruary 28, 2020 13:01
rullzer
rullzer approved these changes Feb 28, 2020
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick!

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 28, 2020
@ChristophWurst

ChristophWurst commented Feb 28, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@ChristophWurst

ChristophWurst commented Feb 28, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@ChristophWurst
ChristophWurst merged commit 0cb0091 into masterFeb 28, 2020
@ChristophWurst
ChristophWurst deleted the feature/revive-send-welcome-email-toggle branch February 28, 2020 16:11
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 28, 2020

Copy link
Copy Markdown

The backport to stable17 failed. Please do this backport manually.

@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 28, 2020

Copy link
Copy Markdown

The backport to stable18 failed. Please do this backport manually.

This was referenced Feb 28, 2020
Merged
Merged
nickvergessen
nickvergessen reviewed Feb 28, 2020
View reviewed changes
Comment threadapps/settings/lib/Controller/UsersController.php
*
* @return JSONResponse
*/
public function setPreference(string $key, string $value): JSONResponse {

@nickvergessennickvergessenFeb 28, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an ocs api to set app configs. It even comes with a nice JS api for it

@tobiasKaminsky

tobiasKaminsky commented Mar 10, 2020

Copy link
Copy Markdown
Member

/backport to stable-16

@tobiasKaminsky

tobiasKaminsky commented Mar 10, 2020

Copy link
Copy Markdown
Member

/backport to stable16

@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 10, 2020

Copy link
Copy Markdown

The backport to stable16 failed. Please do this backport manually.

@skjnldsv

skjnldsv commented Apr 10, 2020

Copy link
Copy Markdown
Member

/backport to stable16

@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 10, 2020

Copy link
Copy Markdown

The backport to stable16 failed. Please do this backport manually.

@ChristophWurst

ChristophWurst commented Apr 10, 2020

Copy link
Copy Markdown
MemberAuthor

We don't need this in 16.

@skjnldsv

skjnldsv commented Apr 10, 2020

Copy link
Copy Markdown
Member

ok :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@rullzerrullzerrullzer approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@GretaDGretaDAwaiting requested review from GretaD

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementregression

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

Missing setting to send welcome mail when creating a user

5 participants

@ChristophWurst@tobiasKaminsky@skjnldsv@rullzer@nickvergessen