Skip to content

Also cache avatars when it's not allowed - #19694

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/cache-404-avatar-responses-too
Feb 28, 2020
Merged

Also cache avatars when it's not allowed#19694
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/cache-404-avatar-responses-too

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Steps

  1. Open a private window
  2. Open dev tools with network tab
  3. Load https://cloud.nextcloud.com/call/c7fz9qpr
  4. See hundreds of requests for avatars with 404 (dont be confused, it will go down to 200 avatar requests when chat loading for guests is fixed with Correctly get new messages for guests spreed#3021 )

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@nickvergessennickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 28, 2020
@nickvergessen
nickvergessen merged commit 7b7d69d into masterFeb 28, 2020
@nickvergessen
nickvergessen deleted the bugfix/noid/cache-404-avatar-responses-too branch February 28, 2020 11:28
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable18 in #19696

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@juliusknorr@skjnldsv