Uh oh!
There was an error while loading. Please reload this page.
Fix default action for deleted shares - #19698
Conversation
45cb7cb to
c510a60CompareThere was a problem hiding this comment.
Still pending:
- Although right now the link can not be clicked there is still a link; probably the
aelement should be replaced withpor something like that whendefaultFileActionsDisabled === true(and in that case maybe thepreventDefault()will be no longer needed). - Whether the link is replaced with a different element or not, the cursor when hovering on the name and the thumbnail should be the default cursor instead of a pointer cursor, as a pointer cursor conveys that the element being hovered can be interacted with.
|
6ac7d74 to
dff944bCompareUh oh!
There was an error while loading. Please reload this page.
| var renaming = $tr.data('renaming'); | ||
| if (!renaming) { | ||
| if (this._defaultFileActionsDisabled) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
preventDefault() should not be needed now that the a element is replaced by a p element when the default file actions are disabled, but it does no harm either, so 👍
786ef28 to
89f55ebCompare89f55eb to
e8a3699Comparerullzer
commented
Mar 9, 2020
/compile amend / |
Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
e8a3699 to
b201121Comparerullzer
commented
Mar 11, 2020
/backport to stable18 |
rullzer
commented
Mar 11, 2020
/backport to stable17 |
The backport to stable17 failed. Please do this backport manually. |
The backport to stable18 failed. Please do this backport manually. |
MorrisJobke
commented
Oct 14, 2020
Caused a regression that deleted group shares cannot be restored anymore: #23240 |
| "href": linkUrl | ||
| }); | ||
| if (this._defaultFileActionsDisabled) { | ||
| linkElem = $('<p></p>').attr({ |
There was a problem hiding this comment.
I guess the regression is because the sharing code relies on the <a> tag instead of a <p> tag and then some element appending doesn't work anymore.
There was a problem hiding this comment.
Maybe @skjnldsv or @PVince81 can help me here. I can't find anything obvious, but also the file list with their sharing integration is quite a big code base.
Regression can be found in #23240 (comment)
The problem:
When you click the name/thumbnail of a deleted share, you will get a not found message (pic below) which is correct, because the file is deleted and you're not suppose to see a preview. But also you're not suppose to see the error message
Solution:
Not to be able to click on deleted shares