Fix filepicker list not being keyboard tabbable, ref #16494

[jancborchardt]

This is the first part of fixing Accessibility: When trying to move or copy a file, I can no longer pick the destination folder #16494

• "Move or copy" picker list needs to be keyboard tabbable
• When pressing Enter on a folder, that folder should be entered into. Currently the primary action (Move) is performed, which makes it impossible to actually move files

For the second part someone with JS knowledge needs to take over – cc @juliushaertl@skjnldsv

[skjnldsv]

• When pressing Enter on a folder, that folder should be entered into. Currently the primary action (Move) is performed, which makes it impossible to actually move files

I would say too complicated risky?
Until we moved this component to a proper standardized plugin (there is an opened issue somewhere) we should maybe not touch this too much :(

[jancborchardt]

Is there an ETA on standardizing that? Cause the associated issue is already open for half a year and is quite the accessibility issue, making moving files impossible.

[skjnldsv]

making moving files impossible

Ah, then it's more of an issue, sorry I did not understand that :)

[juliusknorr]

It would probably be enough to just make sure those functions are not only triggered on click but also on enter keypress:

server/core/src/OC/dialogs.js

Lines 395 to 400 in aa790a3

	self.$dirTree.on('click','div:not(:last-child)',self,function(event){
	self._handleTreeListSelect(event,type)
	})
	self.$filelist.on('click','tr',function(event){
	self._handlePickerClick(event,$(this),type)
	})

[jancborchardt]

@juliushaertl cool, could you add a commit for that? :)

[jancborchardt]

@juliushaertl any update here? :)

[skjnldsv]

Have you checked #20201
Might be the time for this?

[jancborchardt]

We need to get this in for 19 and also backport to at least 18 to fix accessibility, so big layout changes might not be proper here.

What @juliushaertl talked about should work, no? Just needs someone with JS knowledge to add a commit here.

[juliusknorr]

So unfortunately reacting to the keydown event doesn't work as expected, for some reason a click event on the submit is triggered before and I don't see where this is coming from now. Needs some more investigation.

[jancborchardt]

When we find a fix for this, we should backport to 19 for sure and ideally also 18 because it’s an important accessibility fix. :)

[rullzer]

I'm going to close this. It has been open for ages.
Feel free to reopen if anybody actually continues it ;)