Uh oh!
There was an error while loading. Please reload this page.
Get correct mimetype on objectstores - #19888
Merged
Merged
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
icewind1991
approved these changes
Mar 12, 2020
rullzer
requested review from
ChristophWurst, juliusknorr, kesselb and nickvergessenMarch 12, 2020 14:49
nickvergessen
approved these changes
Mar 12, 2020
| public function getMimeType($path) { | ||
| $path = $this->normalizePath($path); | ||
| $stat = $this->stat($path); |
Member
There was a problem hiding this comment.
Am I missing something or is in that case mime type detection only done by file extension?
server/lib/private/Files/Storage/Common.php
Lines 247 to 253 in 5bf3d1b
Same for the Local storage actually
Shouldn't that at least use the result from stat?MemberAuthor
There was a problem hiding this comment.
For local it makes sense. For objectstore we have nothing better.
In anycase I woud do this for now. And create an issue for the rest.
Member
There was a problem hiding this comment.
OK, thanks, yes I already thought that this would be all we have for object storage.
rullzer
commented
Mar 12, 2020
MemberAuthor
/backport to stable18 |
rullzer
commented
Mar 12, 2020
MemberAuthor
/backport to stable17 |
backport to stable18 in #19916 |
backport to stable17 in #19917 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl