Uh oh!
There was an error while loading. Please reload this page.
Improved vcard photo handling - #19901
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
georgehrke
requested changes
Mar 12, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
skjnldsv
approved these changes
Apr 1, 2020
rullzer
commented
Apr 1, 2020
Member
CI says nope |
nickvergessenforce-pushed
the
bugfix/noid/vcard-photo-handling
branch
from
April 2, 2020 08:47
ff0b444 to
fabec4cComparenickvergessen
commented
Apr 2, 2020
MemberAuthor
@georgehrke final +1? |
georgehrke
requested changes
Apr 2, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rullzer
commented
Apr 14, 2020
Member
sooooo? |
nickvergessen
commented
Apr 15, 2020
MemberAuthor
I'm currently unsure about @georgehrke s comments. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrkeforce-pushed
the
bugfix/noid/vcard-photo-handling
branch
from
April 15, 2020 13:57
fabec4c to
fe4527aComparerullzer
commented
Apr 17, 2020
Member
Good to go now? |
georgehrke
commented
Apr 17, 2020
Member
👍 from my side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.