Uh oh!
There was an error while loading. Please reload this page.
Do not use the instance name as user part of from mail addresses - #19910
Merged
Conversation
This will cause issues since the theming name can contain characters that are not allowed in the local part of the mail address (like spaces) Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
ChristophWurst, blizzz, nickvergessen and rullzerMarch 12, 2020 13:21
kesselb
approved these changes
Mar 13, 2020
nickvergessen
commented
Mar 13, 2020
Member
backport needed or was this only in master? |
juliusknorr
commented
Mar 13, 2020
MemberAuthor
Ah no, we should backport to all maintained versions. |
juliusknorr
commented
Mar 13, 2020
MemberAuthor
/backport to stable18 |
juliusknorr
commented
Mar 13, 2020
MemberAuthor
/backport to stable17 |
juliusknorr
commented
Mar 13, 2020
MemberAuthor
/backport to stable16 |
backport to stable18 in #19924 |
backport to stable17 in #19925 |
backport to stable16 in #19926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will cause issues since the theming name can contain characters
that are not allowed in the local part of the mail address (like spaces).
This can still be configured with a proper mail address using mail_from_address / mail_domain in config.php