Uh oh!
There was an error while loading. Please reload this page.
LDAP Group Backend optimizations - #19919
Merged
Merged
Conversation
blizzzforce-pushed
the
enh/noid/ldpa_group_perf
branch
2 times, most recently
from
March 15, 2020 22:11
ab9f13a to
7d1f0ceComparerullzer
commented
Apr 17, 2020
Member
@blizzz 19? |
- less duplication - profiting of the same cache entry Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- saves some overhead costs - in some occasions saves LDAP requests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Keep a runtime cache of dn-id-mapping Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
enh/noid/ldpa_group_perf
branch
from
April 17, 2020 14:02
7d1f0ce to
090c59fCompareblizzz
marked this pull request as ready for review
April 17, 2020 14:07
blizzz
requested review from
ChristophWurst, juliusknorr, kesselb, rullzer and skjnldsvApril 17, 2020 14:08
blizzzforce-pushed
the
enh/noid/ldpa_group_perf
branch
from
April 17, 2020 15:54
090c59f to
a530f6dCompareblizzzforce-pushed
the
enh/noid/ldpa_group_perf
branch
from
April 23, 2020 16:13
a530f6d to
9f87a3fComparerullzer
approved these changes
Apr 23, 2020
blizzz
commented
Apr 23, 2020
MemberAuthor
Aye! Lemme adjust the formatting commit for the remaining stuff the csfixer is complaining about and then merge |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
enh/noid/ldpa_group_perf
branch
from
April 23, 2020 19:34
9f87a3f to
4babdc0Compareskjnldsv
commented
Apr 24, 2020
Member
Failures seems unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some test scenarios I reduced page loading of users page over
20%40% (with 4k of groups), and OCS calls to fetch user details10% downstagnate (also with 4k groups). Extreme cases of course, but the changes make sense either way. In the end, it is also very individual, depending on the config and setup.