Skip to content

Delete avatar if a user is deleted - #19929

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/user-delete-avatar
Apr 27, 2020
Merged

Delete avatar if a user is deleted#19929
MorrisJobke merged 1 commit into
masterfrom
bugfix/user-delete-avatar

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Mar 13, 2020

Copy link
Copy Markdown
Member

Make sure avatars are properly cleaned up if a user is deleted

@juliusknorrjuliusknorr added this to the Nextcloud 19 milestone Mar 13, 2020
kesselb
kesselb reviewed Mar 13, 2020
View reviewed changes
Comment threadlib/private/Avatar/AvatarManager.php Outdated
@juliusknorr
juliusknorrforce-pushed the bugfix/user-delete-avatar branch from 231541d to 0dba8a4CompareMarch 13, 2020 13:46
nickvergessen
nickvergessen reviewed Mar 13, 2020
View reviewed changes
Comment threadlib/private/Avatar/AvatarManager.php Outdated
nickvergessen
nickvergessen reviewed Mar 13, 2020
View reviewed changes
Comment threadlib/private/Avatar/AvatarManager.php Outdated
@rullzer

rullzer commented Mar 23, 2020

Copy link
Copy Markdown
Member

@juliushaertl mind to address the comments?

@nickvergessen
nickvergessenforce-pushed the bugfix/user-delete-avatar branch from 0dba8a4 to 14a567aCompareMarch 24, 2020 20:13
@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2020
rullzer
rullzer reviewed Mar 25, 2020
View reviewed changes
Comment threadlib/private/EventDispatcher/SymfonyAdapter.php Outdated
@nickvergessen
nickvergessenforce-pushed the bugfix/user-delete-avatar branch from 14a567a to 7cc33b4CompareMarch 25, 2020 13:36
@blizzz

blizzz commented Mar 25, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Now you have failing tests though

...
/drone/src/lib/private/User/User.php:243 /drone/src/apps/settings/tests/Controller/AdminSettingsControllerTest.php:96

@juliusknorr

juliusknorr commented Mar 26, 2020

Copy link
Copy Markdown
MemberAuthor

Let me restart, since those run fine locally.

@juliusknorrjuliusknorr added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 30, 2020
This was referenced Apr 4, 2020
Merged
Merged
This was referenced Apr 15, 2020
Merged
Merged
@rullzerrullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@juliusknorr
Delete avatar if a user is deleted
d74e904
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the bugfix/user-delete-avatar branch from 7cc33b4 to d74e904CompareApril 24, 2020 14:27
@juliusknorr

juliusknorr commented Apr 24, 2020

Copy link
Copy Markdown
MemberAuthor

Let's see if that works.

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 24, 2020
@MorrisJobke
MorrisJobke merged commit 673267c into masterApr 27, 2020
@MorrisJobke
MorrisJobke deleted the bugfix/user-delete-avatar branch April 27, 2020 09:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@kesselbkesselbkesselb left review comments
@georgehrkegeorgehrkegeorgehrke approved these changes
@blizzzblizzzblizzz approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: users and groups

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

7 participants

@juliusknorr@rullzer@blizzz@nickvergessen@georgehrke@kesselb@MorrisJobke