Skip to content

Add app config to disable user flows - #19930

Merged
rullzer merged 1 commit into
masterfrom
enh/19804/wfe-disable-user-flows
Mar 22, 2020
Merged

Add app config to disable user flows#19930
rullzer merged 1 commit into
masterfrom
enh/19804/wfe-disable-user-flows

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Implements #19804

With this admins can disable user flows since they can have quite some impact on the performance of a system and you might not want to give users the ability to define their own flows while still making use of the administrator level ones like file_accesscontrol/automated tagging

Can be enabled by running:
occ config:app:set workflowengine user_scope_disabled --value yes

@juliusknorrjuliusknorr added bug 3. to review Waiting for reviews feature: workflows pending documentation This pull request needs an associated documentation update labels Mar 13, 2020
@juliusknorrjuliusknorr added this to the Nextcloud 19 milestone Mar 13, 2020
@kesselb

Copy link
Copy Markdown
Contributor
  1. Create new automated tagging flow at (user/workflow): Assign tag "Test" to a file named "test.jpg".
  2. Upload a file "test.jpg" and see that a tag "Test" has been assigned.
  3. Run occ config:app:delete workflowengine user_scope_disabled --value yes
  4. Delete "test.jpg"
  5. Upload "test.jpg" and see that no tag "Test" has been assigned.

✔️

  1. occ config:app:delete workflowengine user_scope_disabled --value yes
  2. Section flow is not longer visible in navigation

✔️

  1. occ config:app:delete workflowengine user_scope_disabled --value yes
  2. Try to access settings/user/workflow directly. Seems to work but the page is empty.

✔️

@nickvergessen

Copy link
Copy Markdown
Member

A UI option would be nice, but fine enough for now.

@nickvergessen

Copy link
Copy Markdown
Member

A lot of acceptance tests are failing. Can you rebase/rerun to make sure it was only temp?

@juliusknorr
juliusknorrforce-pushed the enh/19804/wfe-disable-user-flows branch from 840ed40 to 664ff23CompareMarch 20, 2020 11:27
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer
rullzerforce-pushed the enh/19804/wfe-disable-user-flows branch from 664ff23 to e482923CompareMarch 21, 2020 07:58
@rullzer
rullzer merged commit a376f19 into masterMar 22, 2020
@rullzer
rullzer deleted the enh/19804/wfe-disable-user-flows branch March 22, 2020 09:36
@szaimen

Copy link
Copy Markdown
Contributor

Will this be backported to 18?

@juliusknorr

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable18 in #20158

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@kesselb@nickvergessen@szaimen@rullzer