Add mindmap type file icon by ACTom · Pull Request #19942 · nextcloud/server

ACTom · 2020-03-13T19:06:52Z

No description provided.

ACTom

Just add a svg file

kesselb · 2020-03-14T18:52:31Z

Thanks 👍

Are you the creator of the icon?

ACTom · 2020-03-14T19:12:05Z

Yes, but I refer to this picture (https://marinettedognanny.com/wp-content/uploads/2018/10/social_icon.png)

kesselb · 2020-03-14T19:27:11Z

cc @jancborchardt @schiessle

I'm not sure if we are able to use that icon. Mind to have a look for a icon available under MIT license? For example: https://feathericons.com

ACTom · 2020-04-14T15:13:49Z

@kesselb I used Inkscape to redraw this icon, and now I can confirm that this icon was made by me.

By the way, if I want to add mindmap type in core / js / mimetypelist.js, is it better to submit a new PR, or to submit it directly in this PR?

kesselb · 2020-04-14T15:17:17Z

Thanks. Please submit another pr for the mime type.

ACTom · 2020-04-15T00:50:06Z

@kesselb I see that this PR does not have reviewers yet, what do I need to do?

jancborchardt

Could look a but more geometric and the lines are a bit thin, but seems fine.

Any particular reason for the choice of color? Ideally color always means something or is related to e.g. a popular product (like red for PDF).

ACTom · 2020-04-16T13:57:57Z

Any particular reason for the choice of color? Ideally color always means something or is related to e.g. a popular product (like red for PDF).

There is no special reason. This color is chosen because it looks good, and it is different from the colors of other existing formats. You can clearly identify the file type in the list.

ACTom · 2020-04-17T14:30:58Z

@juliushaertl Waiting for your review.

kesselb · 2020-04-17T14:50:52Z

@ACTom https://twitter.com/frankdejonge/status/1236727595670134786 :)

It's already queued for 19 and will be reviewed in time.

ACTom · 2020-04-17T15:29:34Z

@kesselb Oh, I'm sorry, thanks.

skjnldsv · 2020-04-23T08:36:53Z

Why do we need this icon in server?

kesselb · 2020-04-23T08:39:23Z

For mindmap files :) Is there a way to add this image as app?

skjnldsv · 2020-04-23T08:43:16Z

For mindmap files :) Is there a way to add this image as app?

No idea, but can't you not register mimetypes and provide your own img?

skjnldsv

But otherwise, sure

kesselb · 2020-10-14T17:11:54Z

Try: https://github.community/t/update-a-forked-repository-when-the-original-repository-is-updated/1855

(don't forget to backup your work just in case)

ACTom · 2020-10-14T17:16:48Z

Try: https://github.community/t/update-a-forked-repository-when-the-original-repository-is-updated/1855
(don't forget to backup your work just in case)

Thanks, but where to fix Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithModifiedMimetypelistSignatureData fails? It need to modify https://github.com/nextcloud/server/blob/master/tests/lib/IntegrityCheck/CheckerTest.php .

ACTom · 2020-10-15T09:15:26Z

@kesselb I have push a new PR to fix Test\IntegrityCheck\CheckerTest::testVerifyCoreSignatureWithModifiedMimetypelistSignatureData fails#23463

kesselb · 2020-10-15T10:07:32Z

But the test does not fail on master.

Rebase this branch and pull the latest changes from master (this repository not your fork)
Merge your other patch into this branch

Then we can review in one go and also have a recent CI run.

ACTom · 2020-10-15T16:44:44Z

But the test does not fail on master.
No, the fail exists on the master and has nothing to do with this PR, you can try it

kesselb · 2020-10-15T16:57:25Z

I don't see the test failing on a recent CI run: https://drone.nextcloud.com/nextcloud/server/34193

But ignore this for now and rebase this branch to have a recent CI run.

ACTom · 2020-10-17T11:54:13Z

I don't see the test failing on a recent CI run: https://drone.nextcloud.com/nextcloud/server/34193
But ignore this for now and rebase this branch to have a recent CI run.
@kesselb
I don't know if the link test set you gave is complete, but I pull the master code and execute ./autotest.sh or phpunit --bootstrap tests/bootstrap.php tests/lib/IntegrityCheck/CheckerTest.php then all reported that error, so I opened #23463 to fix it.

kesselb · 2020-10-17T13:23:16Z

Please rebase this branch to have a recent CI run.

Signed-off-by: ACTom <i@actom.me>

ACTom · 2020-11-14T14:34:03Z

@ChristophWurst @rullzer Can you review it?

szaimen · 2020-12-21T11:15:26Z

Ping @rullzer

ChristophWurst

Fine by me

Signed-off-by: ACTom <i@actom.me>

szaimen · 2020-12-28T09:38:00Z

🎉

nursoda · 2021-01-15T16:10:20Z

Wait, there's a patch for NC 19 and 21 but not for 20? Or did I overlook something?

kesselb · 2021-01-15T19:10:38Z

21

skjnldsv · 2021-07-15T10:25:06Z

/backport to stable20

ACTom referenced this pull request in nextcloud/files_mindmap Mar 13, 2020
Add icon to mimetype mindmap
ad802f6

ACTom commented Mar 14, 2020
View reviewed changes

ACTom mentioned this pull request Mar 14, 2020
File icon for *.km not shown in Recommendations nextcloud/files_mindmap#95
Closed

kesselb added 3. to review Waiting for reviews enhancement labels Mar 14, 2020

kesselb added this to the Nextcloud 19 milestone Mar 14, 2020

This was referenced Apr 4, 2020
19 beta 2 #20303
Merged
19 beta 3 #20386
Merged

kesselb requested review from jancborchardt and juliusknorr April 15, 2020 06:02

This was referenced Apr 15, 2020
19 beta 4 #20506
Merged
19 Beta 5 #20510
Merged

jancborchardt approved these changes Apr 16, 2020
View reviewed changes

rullzer mentioned this pull request Apr 23, 2020
19 beta 6 #20611
Merged
11 tasks

jancborchardt requested a review from skjnldsv April 23, 2020 08:32

skjnldsv approved these changes Apr 23, 2020
View reviewed changes

juliusknorr approved these changes Apr 23, 2020
View reviewed changes

ACTom added 4 commits October 17, 2020 23:40

Add mindmap type file icon
5ef9f7e
Signed-off-by: ACTom <i@actom.me>

Modify mindmap type file icon
e0aa367
Signed-off-by: ACTom <i@actom.me>

fix Test\IntegrityCheck\CheckerTest tests fail
47ebcdf
Signed-off-by: ACTom <i@actom.me>

fix php-cs check fail(tests/lib/IntegrityCheck/CheckerTest.php)
2d17558
Signed-off-by: ACTom <i@actom.me>

kesselb requested review from ChristophWurst and rullzer October 17, 2020 17:23

kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 17, 2020

ACTom mentioned this pull request Nov 6, 2020
Link shared Mindmap leads to Internal Server error (0.0.22, NC 18.0.6) nextcloud/files_mindmap#122
Open

ChristophWurst approved these changes Dec 21, 2020
View reviewed changes

Comment threadtests/lib/IntegrityCheck/CheckerTest.php

ChristophWurst added this to the Nextcloud 21 milestone Dec 21, 2020

rullzer mentioned this pull request Dec 22, 2020
21 beta3 #24765
Merged
39 tasks

Readd test getOnlyDefaultAliases()
d9db6ae
Signed-off-by: ACTom <i@actom.me>

ChristophWurst approved these changes Dec 28, 2020
View reviewed changes

ChristophWurst merged commit b981cb0 into nextcloud:masterDec 28, 2020

rullzer mentioned this pull request Dec 28, 2020
21 beta4 #24852
Merged
39 tasks

Uh oh!

Uh oh!

Conversation

ACTom commented Mar 13, 2020

Uh oh!

ACTom left a comment

Choose a reason for hiding this comment

Uh oh!

kesselb commented Mar 14, 2020

Uh oh!

ACTom commented Mar 14, 2020

Uh oh!

kesselb commented Mar 14, 2020

Uh oh!

ACTom commented Apr 14, 2020

Uh oh!

kesselb commented Apr 14, 2020

Uh oh!

ACTom commented Apr 15, 2020

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

ACTom commented Apr 16, 2020

Uh oh!

ACTom commented Apr 17, 2020

Uh oh!

kesselb commented Apr 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ACTom commented Apr 17, 2020

Uh oh!

skjnldsv commented Apr 23, 2020

Uh oh!

kesselb commented Apr 23, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skjnldsv commented Apr 23, 2020

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

kesselb commented Oct 14, 2020

Uh oh!

ACTom commented Oct 14, 2020

Uh oh!

ACTom commented Oct 15, 2020

Uh oh!

kesselb commented Oct 15, 2020

Uh oh!

ACTom commented Oct 15, 2020

Uh oh!

kesselb commented Oct 15, 2020

Uh oh!

ACTom commented Oct 17, 2020

Uh oh!

kesselb commented Oct 17, 2020

Uh oh!

ACTom commented Nov 14, 2020

Uh oh!

szaimen commented Dec 21, 2020

Uh oh!

ChristophWurst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szaimen commented Dec 28, 2020

Uh oh!

nursoda commented Jan 15, 2021

Uh oh!

kesselb commented Jan 15, 2021

Uh oh!

skjnldsv commented Jul 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

kesselb commented Apr 17, 2020•
edited
Loading

kesselb commented Apr 23, 2020•
edited
Loading