Skip to content

fix safari useragent for versions with 3 digits - #19954

Merged
rullzer merged 1 commit into
nextcloud:masterfrom
roscomputing:fix/19941/fix_safari_useragent
Mar 15, 2020
Merged

fix safari useragent for versions with 3 digits#19954
rullzer merged 1 commit into
nextcloud:masterfrom
roscomputing:fix/19941/fix_safari_useragent

Conversation

@xklonx

@xklonxxklonx commented Mar 14, 2020•
edited by kesselb
Loading

Copy link
Copy Markdown
Contributor

@xklonx
fix safari useragent for versions with 3 digits
f11dee9
Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
@xklonxxklonx mentioned this pull request Mar 14, 2020
Closed
@kesselb

kesselb commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0 Safari/605.1.15

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.5 Safari/605.1.15

As per https://developers.whatismybrowser.com/useragents/explore/software_name/safari/ both are valid.

@kesselbkesselb added 3. to review Waiting for reviews bug labels Mar 14, 2020
@kesselbkesselb added this to the Nextcloud 19 milestone Mar 14, 2020
@kesselb

kesselb commented Mar 14, 2020

Copy link
Copy Markdown
Contributor

/backport to stable18

@rullzer
rullzer merged commit 0ffa598 into nextcloud:masterMar 15, 2020
@welcome

welcomeBot commented Mar 15, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Mar 15, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Mar 15, 2020

Copy link
Copy Markdown

backport to stable18 in #19966

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@kesselbkesselbkesselb approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

Wrong useragent regex for safari in browserSupportsCspV3

3 participants

@xklonx@kesselb@rullzer