Uh oh!
There was an error while loading. Please reload this page.
Update the target when it isempty after sharing - #19981
Merged
Merged
Conversation
Hooks that listen to it (audit log) benefit from having the target properly set. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
danxuliu, icewind1991, juliusknorr and nickvergessenMarch 16, 2020 13:50
rullzer
commented
Mar 16, 2020
MemberAuthor
/backport to stable18 |
rullzer
commented
Mar 16, 2020
MemberAuthor
/backport to stable17 |
rullzer
commented
Mar 16, 2020
MemberAuthor
/backport to stable16 |
nickvergessen
approved these changes
Mar 17, 2020
nickvergessen
left a comment
Member
There was a problem hiding this comment.
yes, although I think the audit app should not listen to target, but source?
rullzer
commented
Mar 17, 2020
MemberAuthor
yeah, there should be a better way for this I agree ;) But this is the quick fix. |
juliusknorr
approved these changes
Mar 18, 2020
backport to stable18 in #20016 |
backport to stable17 in #20017 |
backport to stable16 in #20018 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooks that listen to it (audit log) benefit from having the target
properly set.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl