Print error message again, when 3rdparty submodule is not initialized by blizzz · Pull Request #20 · nextcloud/server

blizzz · 2016-06-07T18:02:35Z

old code used Response which attempted to use OC::$server which is not
and cannot be intialised at this part of the code.

LukasReschke · 2016-06-07T22:04:15Z

👍

MorrisJobke · 2016-06-07T22:16:32Z

Tested and works 👍

- old code used Response which attempted to use OC::$server which is not and cannot be intialised at this part of the code.

blizzz · 2016-06-08T08:35:12Z

rebased

MorrisJobke · 2016-06-08T09:40:52Z

Also port to stable9?

* caused by a concurrect insert that happens between the INSERT and it's sub-SELECT which was there to actually avoid it within insertIfNotExists - sub selects are not atomic and allow this * see also #12315 Avoids an error that has this stack trace: ``` Doctrine\DBAL\Exception\UniqueConstraintViolationException An exception occurred while executing 'INSERT INTO "oc_file_locks" ("key","lock","ttl") SELECT ?,?,? FROM "oc_file_locks" WHERE "key" = ? HAVING COUNT(*) = 0' with params ["files/737d52477f1fb583a5bfe5eb33e820da", 1, 1524066628, "files/737d52477f1fb583a5bfe5eb33e820da"]: SQLSTATE[23505]: Unique violation: 7 ERROR: duplicate key value violates unique constraint "lock_key_index" DETAIL: Key (key)=(files/737d52477f1fb583a5bfe5eb33e820da) already exists. #0 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php(128): Doctrine\DBAL\Driver\AbstractPostgreSQLDriver->convertException('An exception oc...', Object(Doctrine\DBAL\Driver\PDOException)) #1 3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php(1015): Doctrine\DBAL\DBALException::driverExceptionDuringQuery(Object(Doctrine\DBAL\Driver\PDOPgSql\Driver), Object(Doctrine\DBAL\Driver\PDOException), 'INSERT INTO "oc...', Array) #2 lib/private/DB/Connection.php(213): Doctrine\DBAL\Connection->executeUpdate('INSERT INTO "oc...', Array, Array) #3 lib/private/DB/Adapter.php(114): OC\DB\Connection->executeUpdate('INSERT INTO "oc...', Array)\n#4 lib/private/DB/Connection.php(251): OC\DB\Adapter->insertIfNotExist('*PREFIX*file_lo...', Array, Array)\n#5 lib/private/Lock/DBLockingProvider.php(118): OC\DB\Connection->insertIfNotExist('*PREFIX*file_lo...', Array, Array)\n#6 lib/private/Lock/DBLockingProvider.php(163): OC\Lock\DBLockingProvider->initLockField('files/737d52477...', 1) #7 lib/private/Files/Storage/Common.php(704): OC\Lock\DBLockingProvider->acquireLock('files/737d52477...', 1) #8 lib/private/Files/View.php(1931): OC\Files\Storage\Common->acquireLock('files/Documents', 1, Object(OC\Lock\DBLockingProvider)) #9 lib/private/Files/View.php(2041): OC\Files\View->lockPath('/*******/files/...', 1, false) #10 lib/private/Files/Node/Node.php(360): OC\Files\View->lockFile('/*******/files/...', 1) #11 apps/files_sharing/lib/Controller/ShareAPIController.php(928): OC\Files\Node\Node->lock(1) #12 apps/files_sharing/lib/Controller/ShareAPIController.php(589): OCA\Files_Sharing\Controller\ShareAPIController->lock(Object(OC\Files\Node\Folder)) #13 [internal function]: OCA\Files_Sharing\Controller\ShareAPIController->getShares('true', 'false', 'false', Object(OC\Files\Node\Folder), 'false') #14 lib/private/AppFramework/Http/Dispatcher.php(160): call_user_func_array(Array, Array) #15 lib/private/AppFramework/Http/Dispatcher.php(90): OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\Files_Sharing\Controller\ShareAPIController), 'getShares') #16 lib/private/AppFramework/App.php(114): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Files_Sharing\Controller\ShareAPIController), 'getShares') #17 lib/private/AppFramework/Routing/RouteActionHandler.php(47): OC\AppFramework\App::main('OCA\\Files_Shari...', 'getShares', Object(OC\AppFramework\DependencyInjection\DIContainer), Array) #18 [internal function]: OC\AppFramework\Routing\RouteActionHandler->__invoke(Array) #19 lib/private/Route/Router.php(299): call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array) #20 ocs/v1.php(78): OC\Route\Router->match('/ocsapp/apps/fi...') #21 ocs/v2.php(23): require_once('/usr/share/weba...') #22 {main} ```` Signed-off-by: Morris Jobke <hey@morrisjobke.de>

when $share === false then (int)$share['share_type'] will always be equal to (int)0 which results in following crash: [root@server nextcloud]# sudo -u apache php occ files:scan someuser The current PHP memory limit is below the recommended value of 512MB. Starting scan for user 1 out of 1 (someuser) An unhandled exception has been thrown: TypeError: Argument 1 passed to OC\OCS\DiscoveryService::discover() must be of the type string, null given, called in /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php on line 382 and defined in /var/www/html/nextcloud/lib/private/OCS/DiscoveryService.php:65 Stack trace: #0 /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php(382): OC\OCS\DiscoveryService->discover(NULL, 'FEDERATED_SHARI...') nextcloud#1 /var/www/html/nextcloud/apps/files_sharing/lib/External/Manager.php(527): OCA\Files_Sharing\External\Manager->sendFeedbackToRemote(NULL, NULL, NULL, 'decline') nextcloud#2 /var/www/html/nextcloud/apps/files_sharing/lib/External/Storage.php(216): OCA\Files_Sharing\External\Manager->removeShare('files/Someth...') nextcloud#3 [internal function]: OCA\Files_Sharing\External\Storage->checkStorageAvailability() nextcloud#4 /var/www/html/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(505): call_user_func_array(Array, Array) nextcloud#5 [internal function]: OC\Files\Storage\Wrapper\Wrapper->__call('checkStorageAva...', Array) nextcloud#6 /var/www/html/nextcloud/lib/private/Files/Storage/Wrapper/Wrapper.php(505): call_user_func_array(Array, Array) nextcloud#7 /var/www/html/nextcloud/apps/files_sharing/lib/External/Scanner.php(89): OC\Files\Storage\Wrapper\Wrapper->__call('checkStorageAva...', Array) nextcloud#8 /var/www/html/nextcloud/apps/files_sharing/lib/External/Scanner.php(44): OCA\Files_Sharing\External\Scanner->scanAll() nextcloud#9 /var/www/html/nextcloud/lib/private/Files/Utils/Scanner.php(245): OCA\Files_Sharing\External\Scanner->scan('', true, 3) nextcloud#10 /var/www/html/nextcloud/apps/files/lib/Command/Scan.php(172): OC\Files\Utils\Scanner->scan('/someuser', true, NULL) nextcloud#11 /var/www/html/nextcloud/apps/files/lib/Command/Scan.php(249): OCA\Files\Command\Scan->scanFiles('someuser', '/someuser', false, Object(Symfony\Component\Console\Output\ConsoleOutput), false, true, false) nextcloud#12 /var/www/html/nextcloud/3rdparty/symfony/console/Command/Command.php(251): OCA\Files\Command\Scan->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud#13 /var/www/html/nextcloud/core/Command/Base.php(162): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud#14 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(946): OC\Core\Command\Base->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud#15 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(248): Symfony\Component\Console\Application->doRunCommand(Object(OCA\Files\Command\Scan), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud#16 /var/www/html/nextcloud/3rdparty/symfony/console/Application.php(148): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud#17 /var/www/html/nextcloud/lib/private/Console/Application.php(213): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) nextcloud#18 /var/www/html/nextcloud/console.php(96): OC\Console\Application->run() nextcloud#19 /var/www/html/nextcloud/occ(11): require_once('/var/www/html/n...') nextcloud#20 {main}[root@server nextcloud]#

fixes this error caused when system has usernames that are purely numeric. An unhandled exception has been thrown: Error: Object of class OCA\User_LDAP\User\User could not be converted to string in /var/www/nextcloud/apps/user_ldap/lib/User_LDAP.php:312 Stack trace: #0 [internal function]: OCA\User_LDAP\User_LDAP->userExistsOnLDAP() nextcloud#1 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(126): call_user_func_array() nextcloud#2 /var/www/nextcloud/apps/user_ldap/lib/Proxy.php(140): OCA\User_LDAP\User_Proxy->walkBackends() nextcloud#3 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(262): OCA\User_LDAP\Proxy->handleRequest() nextcloud#4 /var/www/nextcloud/apps/user_ldap/lib/User_Proxy.php(239): OCA\User_LDAP\User_Proxy->userExistsOnLDAP() nextcloud#5 /var/www/nextcloud/lib/private/User/Manager.php(168): OCA\User_LDAP\User_Proxy->userExists() nextcloud#6 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(399): OC\User\Manager->get() nextcloud#7 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(226): OCA\Files_FullTextSearch\Service\FilesService->initFileSystems() nextcloud#8 /var/www/nextcloud/apps/files_fulltextsearch/lib/Provider/FilesProvider.php(246): OCA\Files_FullTextSearch\Service\FilesService->getChunksFromUser() nextcloud#9 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(174): OCA\Files_FullTextSearch\Provider\FilesProvider->generateChunks() nextcloud#10 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(403): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser() nextcloud#11 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(280): OCA\FullTextSearch\Command\Index->indexProvider() nextcloud#12 /var/www/nextcloud/3rdparty/symfony/console/Command/Command.php(298): OCA\FullTextSearch\Command\Index->execute() nextcloud#13 /var/www/nextcloud/core/Command/Base.php(177): Symfony\Component\Console\Command\Command->run() nextcloud#14 /var/www/nextcloud/3rdparty/symfony/console/Application.php(1040): OC\Core\Command\Base->run() nextcloud#15 /var/www/nextcloud/3rdparty/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand() nextcloud#16 /var/www/nextcloud/3rdparty/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun() nextcloud#17 /var/www/nextcloud/lib/private/Console/Application.php(206): Symfony\Component\Console\Application->run() nextcloud#18 /var/www/nextcloud/console.php(100): OC\Console\Application->run() nextcloud#19 /var/www/nextcloud/occ(11): require_once('...') nextcloud#20 {main}roopico /var/www/nextcloud/apps/user_ldap/lib/User/OfflineUser.phparch:index Signed-off-by: Alexie Papanicolaou <alpapan@gmail.com>

blizzz added bug 3. to review Waiting for reviews labels Jun 7, 2016

blizzz added this to the Nextcloud 9 milestone Jun 7, 2016

Print error message again, when 3rdparty submodule is not initialized
39aeebf
- old code used Response which attempted to use OC::$server which is not and cannot be intialised at this part of the code.

blizzz force-pushed the fix-3rdparty-notice branch from 551f5b6 to 39aeebfCompare June 8, 2016 08:34

blizzz merged commit bc8fe82 into masterJun 8, 2016

blizzz deleted the fix-3rdparty-notice branch June 8, 2016 08:59

This was referenced Jun 8, 2016
[stabble9] Fix 3rdparty notice stable9 #21
Closed
[stable9] Print error message again, when 3rdparty submodule is not initialized #22
Merged

nccguru mentioned this pull request Jun 22, 2016
Show proper feedback in upload progress bar - seems to hang at 100% #202
Closed

kuimovvg mentioned this pull request Mar 25, 2017
Wrong alghoritm work with coding in external storage, for example webdav #4036
Closed

ruedigerkupper mentioned this pull request Nov 27, 2017
File cache table excessively large (and does not shrink after data removal) / Nextcloud should defragment file cache table #7312
Open

MarioKlebsch mentioned this pull request Dec 4, 2017
Integrity constraint violation: 19 NOT NULL constraint failed: oc_filecache.storage_mtime #7389
Closed

DarkAxi0m mentioned this pull request Dec 15, 2017
S3 Primary Storage In Asia Pacific (Sydney) not working; The authorization header is malformed #7524
Closed

jasondaigo mentioned this pull request Feb 13, 2018
mimetypes not registered anymore; occ file scan stopped working #8342
Closed

Yeru-314 mentioned this pull request Feb 19, 2018
Exception while scanning AND occ files:scan doesn't fix it #8437
Closed

warnerbryce mentioned this pull request Apr 30, 2018
NC Client Uploading some files - Error Could not resolve filesService! Class filesService does not exist #9351
Closed

biljol mentioned this pull request Jun 14, 2018
FUll text search indexing #9870
Closed

dnsinformatic mentioned this pull request Aug 23, 2018
500 error ( Internal Server Eror) #10819
Closed

willymiti mentioned this pull request Sep 5, 2018
After Upgrade to 13.0.6.1 File Not Found in Node.php related to app files_trashbin #11079
Closed

Gooberpatrol66 mentioned this pull request Sep 6, 2018
Relation does not exist #11085
Closed

antoine-mesobfc mentioned this pull request Oct 24, 2018
blank page and scan failed : Error: Call to a member function instanceOfStorage() on null #12017
Closed

fretn mentioned this pull request Jan 24, 2019
Fix for crashing occ files:scan #13789
Closed

OsiMood mentioned this pull request May 22, 2020
Upgrade error to 19 RC3 #21067
Closed

sunjam mentioned this pull request Sep 27, 2020
Update to 20.0.0RC2 fails from beta4. Could not copy "/data/nextcloud/apps/dashboard/js/dashboard.js.map" #23068
Closed

LicoMonch mentioned this pull request Oct 8, 2020
Upgrade 19.0.3 to 19.0.4 via cli-updater: occ upgrade failed #23289
Closed

ArmyOfMonkies mentioned this pull request Oct 15, 2020
Upgrade from Nextcoud 19.0.4 to 20.0.0 fails during execution of occ upgrade nextcloud/news#876
Closed

Floppik mentioned this pull request Dec 1, 2020
Error: Interface 'OCP\AppFramework\Bootstrap\IBootstrap' not found when upgrade from Nextcloud 19.0.4 to Nextcloud 19.0.5 #24286
Closed

tuxcrafter mentioned this pull request Dec 30, 2020
Invalid request for Invalid path files_external/3rdparty/icewind/smb/src/Native/NativeShare.php support for characters like : and | #24924
Closed

GutHib mentioned this pull request Jan 22, 2021
Show latest stable version on upgrade page #25266
Closed

jasysadmin mentioned this pull request Apr 11, 2021
Cannot execute occ files:scan on users authenticated on LDAP #26505
Closed

Bevito mentioned this pull request Apr 22, 2021
occ files:scan : Argument 1 passed to Icewind\SMB\BasicAuth::__construct() must be of the type string, null given #26697
Closed

giacomo892 mentioned this pull request Jul 8, 2021
Bug in DnsPinMiddleware.php, unable to resolve hostname #27870
Closed

xev-pcjc mentioned this pull request Jul 8, 2021
PHP Stacktrace updating to 22 #27873
Closed

This was referenced Jul 20, 2021
Found error in code. Pls check #28058
Closed
Exception during scan: An exception occurred while executing 'SELECT filecache.fileid, storage, path, path_hash, #28076
Closed

skjnldsv mentioned this pull request Jul 23, 2021
Fix tests in files_versions #28132
Merged

cyberpower678 mentioned this pull request Sep 28, 2021
Getting DNS Query Failed when running occ files:scan --all#28979
Closed

dominikmebs mentioned this pull request Oct 1, 2021
Upgrade Error - ValueError: str_repeat(): Argument #2 ($times) must be greater than or equal to 0 #29023
Closed

doc75 mentioned this pull request Feb 5, 2022
[Bug]: After upgrade from PostgreSQL 13 to 14, Nextcloud is KO #31030
Closed
8 tasks

PichlAlex mentioned this pull request Feb 10, 2022
[Bug]: occ files:scan-app-data -> Exception during scan: Packets out of order. Expected 1 received 0. Packet size=145 #31113
Closed
8 tasks

smooth-baking-powder mentioned this pull request May 26, 2022
Doctrine\DBAL\Exception\LockWaitTimeoutException: An exception occurred while executing a query: SQLSTATE[HY000]: General error: 1205 Lock wait timeout exceeded; try restarting transaction #27695
Closed

Bevito mentioned this pull request Oct 12, 2022
[Bug]: Can't delete ldap users #34557
Closed
9 tasks

nowatbuer mentioned this pull request Jan 18, 2023
[Bug]: php occ user:delete fails #36222
Closed
9 tasks

IanNicki mentioned this pull request Jan 24, 2023
Calendar does not finish loading nextcloud/calendar#3551
Closed

soccerdmon11 mentioned this pull request Feb 8, 2023
occ files:scan generates an exception for .htaccess file #34334
Open
9 tasks

OneTwoBarbecue mentioned this pull request Apr 8, 2023
[Bug]: Unable to delete LDAP-user (remnants) #37632
Closed
9 tasks

proserver1 mentioned this pull request Sep 12, 2023
[Bug]: Error: Interface "OCA\Files_Versions\Versions\INeedSyncVersionBackend" not found #40373
Closed
8 tasks

adrhc mentioned this pull request Sep 17, 2024
[Bug]: TypeError: substr(): Argument #1 ($string) must be of type string, bool given in nextcloud-29.0.7/lib/private/AppFramework/Http/Request.php:784 #48116
Closed
8 tasks

tuxmika35 mentioned this pull request Feb 17, 2026
[Bug]: LDAP "Bind failed: 8: Strong(er) authentication required" on v31->v32 #58363
Open
8 tasks

stoneubi mentioned this pull request Mar 27, 2026
[Bug]: Joplin sync Call to undefined method OC\DB\QueryBuilder\QueryBuilder::execute() (Exception Error) (500) #59250
Closed
8 tasks

pollopolea mentioned this pull request Aug 10, 2026
[Bug]: Oracle: user_ldap fails after upgrade due to quoted identifier case mismatch (OWNCLOUD_NAME vs owncloud_name) #60824
Open
8 tasks

Navigation Menu

Uh oh!

Uh oh!

Print error message again, when 3rdparty submodule is not initialized - #20

Print error message again, when 3rdparty submodule is not initialized#20
blizzz merged 1 commit into
masterfrom
fix-3rdparty-notice

blizzz commented Jun 7, 2016

Uh oh!

LukasReschke commented Jun 7, 2016

Uh oh!

MorrisJobke commented Jun 7, 2016

Uh oh!

blizzz commented Jun 8, 2016

Uh oh!

MorrisJobke commented Jun 8, 2016•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

blizzz commented Jun 7, 2016

Uh oh!

LukasReschke commented Jun 7, 2016

Uh oh!

MorrisJobke commented Jun 7, 2016

Uh oh!

blizzz commented Jun 8, 2016

Uh oh!

MorrisJobke commented Jun 8, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MorrisJobke commented Jun 8, 2016•
edited
Loading