Uh oh!
There was an error while loading. Please reload this page.
Make sure group management works with all types of group names - #20035
Merged
Conversation
juliusknorr
commented
Mar 19, 2020
MemberAuthor
juliusknorrforce-pushed
the
bugfix/group-encode
branch
from
March 19, 2020 15:12
e231b38 to
19c90a7Compareskjnldsv
commented
Mar 19, 2020
Member
Maybe add some phpunit testing? 🙈 |
juliusknorr
commented
Mar 30, 2020
MemberAuthor
Yeah, I'll do that. Anyone has concerns/ideas regarding the double encoding? |
skjnldsv
commented
Mar 30, 2020
Member
Looks sane to me |
Member
Not a fan but if it works...then great! |
juliusknorrforce-pushed
the
bugfix/group-encode
branch
from
April 2, 2020 17:37
19c90a7 to
57bb282Comparejuliusknorr
commented
Apr 2, 2020
MemberAuthor
Added some test cases 😉 |
juliusknorr
commented
Apr 2, 2020
MemberAuthor
/backport to stable18 |
juliusknorrforce-pushed
the
bugfix/group-encode
branch
from
April 9, 2020 07:33
57bb282 to
8082a99Comparejuliusknorr
commented
Apr 9, 2020
MemberAuthor
Rebased and ready for review. |
skjnldsv
approved these changes
Apr 9, 2020
juliusknorrforce-pushed
the
bugfix/group-encode
branch
2 times, most recently
from
April 9, 2020 09:44
ccea55c to
3ec9a01CompareSigned-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsvforce-pushed
the
bugfix/group-encode
branch
from
April 11, 2020 06:28
3ec9a01 to
db90023Compareskjnldsv
commented
Apr 11, 2020
Member
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
bugfix/group-encode
branch
from
April 11, 2020 06:36
db90023 to
c20321eComparebackport to stable18 in #20433 with conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group ids currently don't have any character limitations, which means that you can create groups like "Department A/B" which will fail on both the provisioning API as well as the routes provided by our user management.
This PR ensures that all group ids are encoded and properly handled by both the backend and the frontend then.
I'm not to happy about the double encoding here, but this is the only way that we can keep the groupId as part of the URL without making it a query parameter and therefore breaking the provisioning api.
In general I would prefer to add some character limitation to the group id, similar to how we do it for the user id, where
/is blocked, but that would still leave us with instances that might have those broken ids.