Uh oh!
There was an error while loading. Please reload this page.
[PoC] Allow to uplod avatars via a public API - #20072
Closed
rullzer wants to merge 1 commit into
Closed
Conversation
Fixes#10549 * Avatar must be sqaure * POST must be done using a mutlipart form * Key is avatar Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| // TODO: Return link to avatar? | ||
| } | ||
| public function deleteAvatar(string $userId): DataResponse { |
| $currentLoggedInUser = $this->userSession->getUser(); | ||
| $targetUser = $this->userManager->get($userId); | ||
| if ($targetUser === null) { |
There was a problem hiding this comment.
This should not be needed as you have to be logged in?
| $currentLoggedInUser = $this->userSession->getUser(); | ||
| $targetUser = $this->userManager->get($userId); | ||
| if ($targetUser === null) { |
There was a problem hiding this comment.
see comments from above method
| $file = $this->request->getUploadedFile('avatar'); | ||
| if ($file['size'] > 20 * 1024 * 1024) { |
Member
There was a problem hiding this comment.
I would love to have this as a const somewhere :)
| * @NoAdminRequired | ||
| */ | ||
| public function getAvatar(string $userId): DataResponse { | ||
| // TODO: Return link to avatar? |
Member
There was a problem hiding this comment.
yes! Cleaner :)
Optional parameter with size?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#10549
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl