Skip to content

fix mail template - #20118

Closed
mkofahl wants to merge 1 commit into
nextcloud:masterfrom
mkofahl:patch-1
Closed

fix mail template#20118
mkofahl wants to merge 1 commit into
nextcloud:masterfrom
mkofahl:patch-1

Conversation

@mkofahl

Copy link
Copy Markdown

Mail clients may hide the content if the table showing the logo is at 100% height.

@gary-kim

gary-kim commented Mar 23, 2020

Copy link
Copy Markdown
Member

Thank you for your contribution!

Could you add a DCO to your commit? The easiest way would be to add the -s flag from the command line. You can run the following command to add a DCO from the head of your commit: git commit -s --amend then git push --force-with-lease.
Otherwise, you can also add the following to the bottom of your commit message.

Signed-off-by: Random J Developer <random@developer.example.org>

@nickvergessen

Copy link
Copy Markdown
Member

@mkofahl any specific client you had a problem with?

@mkofahl

Copy link
Copy Markdown
Author

@mkofahl any specific client you had a problem with?

Yes, Zimbra.

Mail clients may hide the content if the table showing the logo is at 100% height.
Signed-off-by: Martin Kofahl <martin.kofahl@gmail.com>
This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
@rullzerrullzer mentioned this pull request Apr 23, 2020
11 tasks
@rullzerrullzer removed this from the Nextcloud 19 milestone Apr 30, 2020
@MorrisJobke

Copy link
Copy Markdown
Member

@jancborchardt@skjnldsv Do you think this is okay CSS-wise?

@skjnldsv

Copy link
Copy Markdown
Member

@mkofahl can you post before/after screenshotsplease, we usually like to have direct comparison on design pull requests!
Thanks for your work!! 🚀

@skjnldsvskjnldsv added design Design, UI, UX, etc. feature: emails labels Jul 14, 2020
@J0WI

J0WI commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

ping @mkofahl

@J0WIJ0WI added the stale Ticket or PR with no recent activity label Apr 28, 2021
@MorrisJobke

Copy link
Copy Markdown
Member

Let's close it as we can reopen it at any time anyways.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.feature: emailsstaleTicket or PR with no recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@mkofahl@gary-kim@nickvergessen@MorrisJobke@skjnldsv@J0WI@rullzer