Skip to content

Allow to navigate to others with access from the sidebar - #20262

Merged
rullzer merged 1 commit into
masterfrom
fix/others_with_acces/navigation
Apr 29, 2020
Merged

Allow to navigate to others with access from the sidebar#20262
rullzer merged 1 commit into
masterfrom
fix/others_with_acces/navigation

Conversation

@rullzer

@rullzerrullzer commented Apr 1, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

skjnldsv
skjnldsv reviewed Apr 1, 2020
View reviewed changes
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php
rullzer
rullzer commented Apr 2, 2020
View reviewed changes
Comment threadapps/files_sharing/lib/Controller/ShareAPIController.php
throw new OCSNotFoundException($this->l->t('Could not lock path'));
}

if (!($node->getPermissions() & Constants::PERMISSION_SHARE)) {

@rullzerrullzerApr 2, 2020

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daita any reason you didn't just go with this check?
I'm asking since your confirmresharingrights doesn't work if you and in the sub sub folder of a share.

@rullzerrullzer added this to the Nextcloud 19 milestone Apr 2, 2020
@rullzerrullzer added the 3. to review Waiting for reviews label Apr 2, 2020
This was referenced Apr 4, 2020
Merged
Merged
This was referenced Apr 15, 2020
Merged
Merged
@rullzerrullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@rullzer
rullzerforce-pushed the fix/others_with_acces/navigation branch from 6e38185 to 25907e2CompareApril 29, 2020 09:56
@rullzer

rullzer commented Apr 29, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@rullzer

rullzer commented Apr 29, 2020

Copy link
Copy Markdown
MemberAuthor

To review

  1. Create a bunch of users, user1 user2 user3 user4 user5
  2. user1 creates a folder dep1 and shares it to user 2
  3. user2 creates dep2 in dep1 and shares it to user3 and user 4
  4. user4 creates dep3 in dep2 and shares it to user5
  5. user5 creates dep4 in dep3

Now for example login as user3.
And check the others with access on dep4
You should see the other users. And be able to see what the most common path is both of you have access to.

skjnldsv
skjnldsv approved these changes Apr 29, 2020
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@georgehrke

georgehrke commented Apr 29, 2020

Copy link
Copy Markdown
Member
MasterThis PR
F70F608E-0168-4DB4-9BBE-FC47CB5B45B8E586B2C3-B7A0-4762-BAC3-CAF7ED86FBF6

@georgehrke

georgehrke commented Apr 29, 2020

Copy link
Copy Markdown
Member

@rullzer Is there a separate issue that it doesn't display user1?

@skjnldsv

skjnldsv commented Apr 29, 2020

Copy link
Copy Markdown
Member

@rullzer Is there a separate issue that it doesn't display user1?

Yes, I mentionned it to Roeland already :)

@rullzer

rullzer commented Apr 29, 2020

Copy link
Copy Markdown
MemberAuthor

Right I gues we need to fix that separately yes... But let me first rebase this and get it in and then I look at that case

@rullzer
rullzerforce-pushed the fix/others_with_acces/navigation branch from 25907e2 to 3eb2e9bCompareApril 29, 2020 17:42
@rullzer

rullzer commented Apr 29, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@rullzer@npmbuildbot
Allow to navigate to others with access from the sidebar
d466a7b
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the fix/others_with_acces/navigation branch from 3eb2e9b to d466a7bCompareApril 29, 2020 17:53
@rullzer
rullzer merged commit 8247576 into masterApr 29, 2020
@rullzer
rullzer deleted the fix/others_with_acces/navigation branch April 29, 2020 19:32
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 29, 2020

Copy link
Copy Markdown

The backport to review failed. Please do this backport manually.

@rullzer

rullzer commented Apr 30, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 30, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgehrkegeorgehrkegeorgehrke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@wiswedelwiswedelAwaiting requested review from wiswedel
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@georgehrke@skjnldsv