Uh oh!
There was an error while loading. Please reload this page.
fixes the throttler not checking the user state on postLogin - #20299
Merged
Conversation
a listener to the post login events can still reject a login, so that a user is not necessarily available at the time. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
ChristophWurst
approved these changes
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A listener to the post login events can still reject a login, so that a user is not necessarily available at the time.
\OC\User\Session::completeLogin()checks for it after the events have been sent itself and throws a LoginException.In general this is already very hackish. Perhaps best is when any listener would throw an LoginException directly, but it is private, and also it appears that the designated way of doing things was this. As I don't know what else might cling to this behaviour or not, fixing the listener seems safest for now. Not eager for surprises at the moment.