Skip to content

Use embedded previews of ZIP-like files - #20319

Merged
rullzer merged 5 commits into
masterfrom
enh/noid/embedded-previews
Apr 8, 2020
Merged

Use embedded previews of ZIP-like files#20319
rullzer merged 5 commits into
masterfrom
enh/noid/embedded-previews

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Apr 5, 2020

Copy link
Copy Markdown
Member

Some filetypes like OpenDocument are basically just zip files and contain a preview image already that we can extract to provide previews without requiring external dependencies.

This implements an abstract class to extract as well as two providers for OpenDocument and Krita files.

@juliusknorrjuliusknorr added the 3. to review Waiting for reviews label Apr 5, 2020
@juliusknorrjuliusknorr added this to the Nextcloud 19 milestone Apr 5, 2020
skjnldsv
skjnldsv approved these changes Apr 5, 2020
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is so awesome!!
Code looks good!

Maybe some tests? 🙈

@skjnldsv
skjnldsv requested a review from georgehrkeApril 5, 2020 09:09
@juliusknorr

juliusknorr commented Apr 5, 2020

Copy link
Copy Markdown
MemberAuthor

Hm, not sure how I can properly write tests for that as the preview providers don't support DI yet.

@skjnldsv

skjnldsv commented Apr 5, 2020

Copy link
Copy Markdown
Member

Hm, not sure how I can properly write tests for that as the preview providers don't support DI yet.

Ah ok :)

@skjnldsv

skjnldsv commented Apr 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Code looks good!

Ah, that was not done! I was happy this looked so simple with the first commits 🙈

@juliusknorr

juliusknorr commented Apr 5, 2020

Copy link
Copy Markdown
MemberAuthor

It is now, I just forgot to push a new file and bump the autoloader.

nickvergessen
nickvergessen reviewed Apr 5, 2020
View reviewed changes
Comment threadlib/private/Preview/Krita.php Outdated
@@ -0,0 +1,53 @@
<?php
/**
* @copyright Copyright (c) 2016, ownCloud, Inc.

@nickvergessennickvergessenApr 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

@kesselb

kesselb commented Apr 5, 2020

Copy link
Copy Markdown
Contributor

Nice 👍 Works for me 🎉

server/config/config.sample.php

Lines 981 to 1032 in 53db05a

/**
* Only register providers that have been explicitly enabled
*
* The following providers are disabled by default due to performance or privacy
* concerns:
*
* - OC\Preview\Illustrator
* - OC\Preview\Movie
* - OC\Preview\MSOffice2003
* - OC\Preview\MSOffice2007
* - OC\Preview\MSOfficeDoc
* - OC\Preview\OpenDocument
* - OC\Preview\PDF
* - OC\Preview\Photoshop
* - OC\Preview\Postscript
* - OC\Preview\StarOffice
* - OC\Preview\SVG
* - OC\Preview\TIFF
* - OC\Preview\Font
*
* The following providers are not available in Microsoft Windows:
*
* - OC\Preview\Movie
* - OC\Preview\MSOfficeDoc
* - OC\Preview\MSOffice2003
* - OC\Preview\MSOffice2007
* - OC\Preview\OpenDocument
* - OC\Preview\StarOffice
*
* Defaults to the following providers:
*
* - OC\Preview\BMP
* - OC\Preview\GIF
* - OC\Preview\HEIC
* - OC\Preview\JPEG
* - OC\Preview\MarkDown
* - OC\Preview\MP3
* - OC\Preview\PNG
* - OC\Preview\TXT
* - OC\Preview\XBitmap
*/
'enabledPreviewProviders' => [
'OC\Preview\PNG',
'OC\Preview\JPEG',
'OC\Preview\GIF',
'OC\Preview\HEIC',
'OC\Preview\BMP',
'OC\Preview\XBitmap',
'OC\Preview\MP3',
'OC\Preview\TXT',
'OC\Preview\MarkDown'
],
Please update accordingly.

kesselb
kesselb approved these changes Apr 5, 2020
View reviewed changes
Comment threadlib/private/Preview/Bundled.php
Comment threadlib/private/Preview/Bundled.php Outdated
@rullzerrullzer mentioned this pull request Apr 7, 2020
Merged
80 tasks
@rullzer

rullzer commented Apr 8, 2020

Copy link
Copy Markdown
Member

@juliushaertl please address the comments and we can get this in

@juliusknorr
Add abstract class to extract previews from files that are zip archives
0734582
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Extract preview from opendocument files
a2e671c
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Add preview provider for Krita files
124b109
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump autoloaders
6c0b603
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
remove Windows config since it is not supported anyways
5d27ed5
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the enh/noid/embedded-previews branch from e843c89 to 5d27ed5CompareApril 8, 2020 14:31
@juliusknorr

juliusknorr commented Apr 8, 2020

Copy link
Copy Markdown
MemberAuthor

Done

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish enhancement feature: previews and thumbnails and removed 3. to review Waiting for reviews labels Apr 8, 2020
@rullzer
rullzer merged commit 37146c9 into masterApr 8, 2020
@rullzer
rullzer deleted the enh/noid/embedded-previews branch April 8, 2020 17:33
@joshtrichardsjoshtrichards mentioned this pull request May 30, 2025
Open
@joshtrichardsjoshtrichards mentioned this pull request Oct 28, 2025
Open
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@kesselbkesselbkesselb approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: previews and thumbnails

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@skjnldsv@kesselb@rullzer@nickvergessen