tests: fix failing header acceptance test

[azul]

The username is listed in a div with class fullname now.

[azul]

Looks like there are acceptance tests in 3 files failing right now:

 /nextcloud/tests/acceptance/features/app-comments.feature:21
/nextcloud/tests/acceptance/features/app-comments.feature:233
/nextcloud/tests/acceptance/features/app-comments.feature:288
/nextcloud/tests/acceptance/features/app-comments.feature:308
/nextcloud/tests/acceptance/features/app-files-sharing-link.feature:26
/nextcloud/tests/acceptance/features/app-files-sharing-link.feature:135
/nextcloud/tests/acceptance/features/header.feature:24
/nextcloud/tests/acceptance/features/header.feature:31
/nextcloud/tests/acceptance/features/header.feature:44
/nextcloud/tests/acceptance/features/header.feature:65

This one fixes the last.

I'm happy to continue working on these to get a green CI.
Is there a way to get screenshots or html dumps of failing acceptance tests?
I'm currently running them with

tests/acceptance/run.sh features/app-comments.feature

Is there a faster way that keeps the docker containers up or runs them in the main system?

[gary-kim]

You're probably not going to get reliable green CI. There seem to be some agents on the CI system that are really slow for some reason so @nextcloud/infrastructure probably has to deal with that. Of course, nothing bad about trying to get the tests we have to be correct!

BTW, I also host drone instances so let me know if I can be of help with that?

Is there a faster way that keeps the docker containers up or runs them in the main system?

Take a look at the drone exec command in the Drone CLI

[skjnldsv]

You're probably not going to get reliable green CI.

We improved a lot lately on lowering the load on our CI infrastructure :)
We got some green before, no reason it should not again 🙈

Thanks a lot for the fix on header! Works nicely!!

[gary-kim]

We got some green before, no reason it should not again see_no_evil

It's basically like a betting game. If you do it wrong, of course you lose. If you do it right, then maybe, just maybe, you'll get green ✔️ . :)

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22