Uh oh!
There was an error while loading. Please reload this page.
Use one blank line after the opening tag and namespace declaration - #20379
Merged
Conversation
For PSR2 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
georgehrke, juliusknorr, nickvergessen and tcitworldApril 9, 2020 09:53
juliusknorr
approved these changes
Apr 9, 2020
nickvergessen
approved these changes
Apr 9, 2020
georgehrke
approved these changes
Apr 9, 2020
georgehrke
commented
Apr 9, 2020
Member
Do we also have a standard for number of lines between copyright block and namespace? |
ChristophWurst
commented
Apr 9, 2020
MemberAuthor
Not yet, I think. But IIRC there is also an PSR for the order of declare, header, namespace and so on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step to bring us closer to PSR2.