Uh oh!
There was an error while loading. Please reload this page.
Use php keywords in lowercase - #20384
Merged
Merged
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
blizzz, georgehrke, juliusknorr, nickvergessen and tcitworldApril 9, 2020 12:06
| $adminAccountIsSet = isset($post['adminlogin']); | ||
| if ($dbIsSet AND $directoryIsSet AND $adminAccountIsSet) { | ||
| if ($dbIsSet and $directoryIsSet and $adminAccountIsSet) { |
Member
There was a problem hiding this comment.
Should we replace all and with &&?
MemberAuthor
There was a problem hiding this comment.
Will come with logical_operators => true :)
MemberAuthor
There was a problem hiding this comment.
So sorry for doing this in small steps but I want to avoid breaking something with these cleanups. Thus I do them in a way that is hopefully most reviewable 🙏
ChristophWurst
commented
Apr 9, 2020
MemberAuthor
Oh no I mixed up the PRs and thought this one was reviewed 🙈 Shall I revert? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why would anyone case them? Well, anyway, bringing use yet another step closer to PSR2.