Uh oh!
There was an error while loading. Please reload this page.
Fix absolute redirect - #20401
Merged
Merged
Conversation
skjnldsv
requested review from
ChristophWurst, blizzz, nickvergessen and rullzerApril 10, 2020 06:54
skjnldsv
commented
Apr 10, 2020
MemberAuthor
/backport to stable18 |
skjnldsv
commented
Apr 10, 2020
MemberAuthor
/backport to stable17 |
skjnldsv
commented
Apr 10, 2020
MemberAuthor
/backport to stable16 |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
fix/login-sso-redirct
branch
from
April 10, 2020 06:59
0e19820 to
6c49dc2Comparebackport to stable18 in #20495 |
backport to stable17 in #20496 |
backport to stable16 in #20497 with conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#6822
It will just not work for url with like a hash in it.
Because we moved all of our apps to proper javascript url history, this should not be an issue anymore.