Skip to content

Use elseif instead of else if - #20402

Merged
skjnldsv merged 1 commit into
masterfrom
techdebt/elseif
Apr 10, 2020
Merged

Use elseif instead of else if#20402
skjnldsv merged 1 commit into
masterfrom
techdebt/elseif

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Apr 10, 2020

Copy link
Copy Markdown
Member

PSR2 requires braces around every control structure, so if you have

if ($a) {
//
} elseif ($b) {
//
}

it will transform your code to

if ($a) {
//
} else {
if ($b) {
//
}
}

With elseifthe structure can remain unchanged.

@ChristophWurst
Use elseif instead of else if
14c996d
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Apr 10, 2020
@ChristophWurstChristophWurst added this to the Nextcloud 19 milestone Apr 10, 2020
@ChristophWurstChristophWurst self-assigned this Apr 10, 2020
rullzer
rullzer approved these changes Apr 10, 2020
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 10, 2020
@skjnldsv
skjnldsv merged commit 71b0738 into masterApr 10, 2020
@skjnldsv
skjnldsv deleted the techdebt/elseif branch April 10, 2020 11:28
@rullzerrullzer mentioned this pull request Apr 13, 2020
Merged
59 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@gary-kimgary-kimgary-kim approved these changes
@kesselbkesselbAwaiting requested review from kesselb
@xh3n1xh3n1Awaiting requested review from xh3n1

Assignees

@ChristophWurstChristophWurst

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst@rullzer@skjnldsv@gary-kim