Uh oh!
There was an error while loading. Please reload this page.
Fix password reset saying Admin changed my password when reset from login page - #20427
Merged
Conversation
login page Signed-off-by: Thomas Citharel <tcit@tcit.fr>
nickvergessen
approved these changes
Apr 10, 2020
tcitworld
commented
Apr 13, 2020
MemberAuthor
Does this needs backports? |
nickvergessen
commented
Apr 15, 2020
Member
Should backport after the maintenance releases next week so translators had enough time to translate? |
MorrisJobke
commented
May 25, 2020
Member
/backport to stable18 |
MorrisJobke
commented
May 25, 2020
Member
/backport to stable17 |
MorrisJobke
commented
May 25, 2020
Member
/backport to stable16 |
The backport to stable18 failed. Please do this backport manually. |
The backport to stable16 failed. Please do this backport manually. |
The backport to stable17 failed. Please do this backport manually. |
nickvergessen
commented
Jun 4, 2020
Member
@tcitworld can you manually do a backport to 18 and 17? |
nickvergessen
commented
Jun 4, 2020
Member
/backport to stable19 |
The backport to stable19 failed. Please do this backport manually. |
tcitworld
commented
Jun 4, 2020
MemberAuthor
Done for 17 and 18. 19 already has this. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resetting my password without being logged in I was getting the wrong message (there's no session since we're logged out, and it assumed it was an admin action).
Before : "Your password was reset by an administrator"
After : "Your password was reset"
Not sure if this covers all cases, but at least the message stays valid.