Uh oh!
There was an error while loading. Please reload this page.
Always try and show pre rendered preview - #20451
Merged
MorrisJobke merged 2 commits intoAug 13, 2020
Merged
Conversation
icewind1991
approved these changes
Apr 14, 2020
rullzer
commented
Apr 14, 2020
Member
@exussum12 seems the test fail. Mind to have a look? |
exussum12force-pushed
the
AllowPreviewWhenGeneratorHasBeenRemoved
branch
from
April 18, 2020 19:09
5c6ea6d to
4ab6721Comparejuliusknorr
commented
Apr 24, 2020
Member
There still seems to be an issue with one test: |
Currently if the following situation happens Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets a 404 error when preview exists (Mime checked before preview) This happens more often with documents, or video as the commands are not native PHP, they require a binary on the server. After the fix the following would happen Server generates preview Server has command removed which allows a preview to be shown Client asks for preview, gets preview which has been generated (Mime checked after preview) This would also allow offline generation (for example a docker image containing the extra binaries), allowing a reduction in attack surface of the instance serving the preview data. Signed-off-by: Scott Dutton <scott@exussum.co.uk>
MorrisJobkeforce-pushed
the
AllowPreviewWhenGeneratorHasBeenRemoved
branch
from
August 13, 2020 20:50
4ab6721 to
b12a390CompareMorrisJobke
commented
Aug 13, 2020
Member
Rebased to check the tests again. |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
commented
Aug 13, 2020
Member
I fixed the test and added one specifically for this new use case. |
MorrisJobke
commented
Aug 13, 2020
Member
CI also likes it -> merge \o/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the following situation happens
Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets a 404 error when preview exists
(Mime checked before preview)
This happens more often with documents, or video as the commands are not
native PHP, they require a binary on the server.
After the fix the following would happen
Server generates preview
Server has command removed which allows a preview to be shown
Client asks for preview, gets preview which has been generated
(Mime checked after preview)
This would also allow offline generation (for example a docker image
containing the extra binaries), allowing a reduction in attack surface
of the instance serving the preview data.