Skip to content

Fix jsunit tests - #20470

Merged
skjnldsv merged 1 commit into
masterfrom
fix/noid/karma-coverage
Apr 14, 2020
Merged

Fix jsunit tests#20470
skjnldsv merged 1 commit into
masterfrom
fix/noid/karma-coverage

Conversation

@kesselb

@kesselbkesselb commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.

skjnldsv
skjnldsv approved these changes Apr 14, 2020
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@kesselb

kesselb commented Apr 14, 2020

Copy link
Copy Markdown
ContributorAuthor

Shit 🙈 ^2.0.1 is also matching 2.0.2 🤣 Probably the error is gone if you use a newer node version for running the tests. I'm not able to reproduce locally with Node 10.3.

@kesselb
Fix jsunit tests
0ccaec9
JSUnit tests are failing for some reason. It seems to be related to a new karma-coverage version published a few hours ago.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the fix/noid/karma-coverage branch from ad322df to 0ccaec9CompareApril 14, 2020 09:55
MorrisJobke
MorrisJobke approved these changes Apr 14, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 14, 2020
@MorrisJobkeMorrisJobke added this to the Nextcloud 19 milestone Apr 14, 2020
@skjnldsv
skjnldsv merged commit a5c186b into masterApr 14, 2020
@skjnldsv
skjnldsv deleted the fix/noid/karma-coverage branch April 14, 2020 12:35
@rullzerrullzer mentioned this pull request Apr 15, 2020
Merged
59 tasks
@kesselb

kesselb commented Apr 18, 2020

Copy link
Copy Markdown
ContributorAuthor

/backport to stable18

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 18, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 18, 2020

Copy link
Copy Markdown

backport to stable18 in #20548

@kesselbkesselb mentioned this pull request Apr 19, 2020
Merged
This was referenced Apr 23, 2020
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@GretaDGretaDAwaiting requested review from GretaD
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@danxuliudanxuliuAwaiting requested review from danxuliu
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: dependencies

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@MorrisJobke@skjnldsv