Skip to content

Verify that destination is not a directory. - #20472

Merged
rullzer merged 1 commit into
masterfrom
fix/19848/make-sure-destination-is-not-a-directory
Apr 14, 2020
Merged

Verify that destination is not a directory.#20472
rullzer merged 1 commit into
masterfrom
fix/19848/make-sure-destination-is-not-a-directory

Conversation

@kesselb

Copy link
Copy Markdown
Contributor

Fix#19848

Otherwise file_put_contents will fail later.

@kesselb
kesselbforce-pushed the fix/19848/make-sure-destination-is-not-a-directory branch from ec87de3 to 2d61d9eCompareApril 14, 2020 09:59
@kesselbkesselb added 3. to review Waiting for reviews bug labels Apr 14, 2020
@kesselbkesselb added this to the Nextcloud 19 milestone Apr 14, 2020

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Otherwise file_put_contents will fail later.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the fix/19848/make-sure-destination-is-not-a-directory branch from 2d61d9e to 91ab811CompareApril 14, 2020 10:52
@rullzer
rullzer merged commit d7a74d0 into masterApr 14, 2020
@rullzer
rullzer deleted the fix/19848/make-sure-destination-is-not-a-directory branch April 14, 2020 13:20
@rullzerrullzer mentioned this pull request Apr 15, 2020
59 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[18.0.x] WebDAV MOVE: file_put_contents() is a directory

3 participants

@kesselb@rullzer@ChristophWurst