Uh oh!
There was an error while loading. Please reload this page.
Add a wrapper to fall back to the share owner on public shares - #20475
Closed
rullzer wants to merge 1 commit into
Closed
Add a wrapper to fall back to the share owner on public shares#20475rullzer wants to merge 1 commit into
rullzer wants to merge 1 commit into
Conversation
rullzer
requested review from
MorrisJobke, georgehrke, icewind1991, kesselb and nickvergessenApril 14, 2020 12:48
Else it might happen that we setup a storage that has no real owner and activities do boom etc (looking at you groupfolders and external storages!). Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
fix/public_share_owner_activity_mess
branch
from
April 14, 2020 12:49
79cec4d to
909d79aCompareMorrisJobke
commented
Apr 15, 2020
Member
Why was this closed? |
rullzer
commented
Apr 15, 2020
MemberAuthor
Because a different PR from joas fixed it :) |
nickvergessen
commented
Apr 15, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).
Steps
before: 💥
now: 🎸