Skip to content

Update list of multiple properties - #20529

Merged
skjnldsv merged 1 commit into
masterfrom
fix/Card-multiple
Apr 17, 2020
Merged

Update list of multiple properties#20529
skjnldsv merged 1 commit into
masterfrom
fix/Card-multiple

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Apr 17, 2020•
edited
Loading

Copy link
Copy Markdown
Member
in_array($property->name, ['URL', 'GEO', 'CLOUD', 'ADR', 'EMAIL', 'IMPP', 'TEL', 'X-SOCIALPROFILE', 'RELATED', 'LANG', 'X-ADDRESSBOOKSERVER-MEMBER'])

I really hate this!
I'm curious to see if we don't have a valid list somewhere which we wouldn't have to manually update 🤦

@skjnldsvskjnldsv self-assigned this Apr 17, 2020
@skjnldsvskjnldsv added this to the Nextcloud 19 milestone Apr 17, 2020
@skjnldsv

skjnldsv commented Apr 17, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@skjnldsv

skjnldsv commented Apr 17, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@nickvergessennickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2020
@nickvergessen

This comment has been minimized.

Sign in to view
@skjnldsv

skjnldsv commented Apr 17, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Tests pushed with additional testing array :)
Please review!

@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 17, 2020
@skjnldsvskjnldsv mentioned this pull request Apr 17, 2020
Closed
nickvergessen
nickvergessen reviewed Apr 17, 2020
View reviewed changes
Comment threadapps/dav/tests/unit/CardDAV/AddressBookImplTest.php
@skjnldsv
Update list of multiple properties
2954132
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 17, 2020
@skjnldsv
skjnldsv merged commit 7c4b7e9 into masterApr 17, 2020
@skjnldsv
skjnldsv deleted the fix/Card-multiple branch April 17, 2020 08:39
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 17, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 17, 2020

Copy link
Copy Markdown

backport to stable18 in #20531

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 17, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 17, 2020

Copy link
Copy Markdown

backport to stable17 in #20532

@rullzerrullzer mentioned this pull request Apr 17, 2020
Merged
55 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@rullzerrullzerAwaiting requested review from rullzer
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@blizzzblizzzAwaiting requested review from blizzz

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: dav

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@nickvergessen@ChristophWurst