[stable18] dont show remote and email options if we have an exact match for local user email

[backportbot-nextcloud]

backport of #16035

Fixes#20359

[MorrisJobke]

Code looks good 👍

[MorrisJobke]

CI fails:

There were 6 errors:
134 135	1) Test\Collaboration\Collaborators\UserPluginTest::testSearch with data set #10 ('test', false, true, array(), array(Mock_IUser_c8fdc090 Object (...)), array(), array(array('Test One', array(0, 'test1'))), true, false)
136	Error: Call to a member function getDisplayName() on string
137 138	/drone/src/lib/private/Collaboration/Collaborators/UserPlugin.php:101
139	/drone/src/tests/lib/Collaboration/Collaborators/UserPluginTest.php:458
140 141	2) Test\Collaboration\Collaborators\UserPluginTest::testSearch with data set #11 ('test', false, false, array(), array(Mock_IUser_c8fdc090 Object (...)), array(), array(), true, false)
142	Error: Call to a member function getDisplayName() on string
143 144	/drone/src/lib/private/Collaboration/Collaborators/UserPlugin.php:101
145	/drone/src/tests/lib/Collaboration/Collaborators/UserPluginTest.php:458
146 147	3) Test\Collaboration\Collaborators\UserPluginTest::testSearch with data set #12 ('test', false, true, array(), array(Mock_IUser_c8fdc090 Object (...), Mock_IUser_c8fdc090 Object (...)), array(), array(array('Test One', array(0, 'test1')), array('Test Two', array(0, 'test2'))), false, false)
148	Error: Call to a member function getDisplayName() on string
149 150	/drone/src/lib/private/Collaboration/Collaborators/UserPlugin.php:101
151	/drone/src/tests/lib/Collaboration/Collaborators/UserPluginTest.php:458
152 153	4) Test\Collaboration\Collaborators\UserPluginTest::testSearch with data set #13 ('test', false, false, array(), array(Mock_IUser_c8fdc090 Object (...), Mock_IUser_c8fdc090 Object (...)), array(), array(), true, false)
154	Error: Call to a member function getDisplayName() on string
155 156	/drone/src/lib/private/Collaboration/Collaborators/UserPlugin.php:101
157	/drone/src/tests/lib/Collaboration/Collaborators/UserPluginTest.php:458
158 159	5) Test\Collaboration\Collaborators\UserPluginTest::testSearch with data set #14 ('test', false, true, array(), array(Mock_IUser_c8fdc090 Object (...), Mock_IUser_c8fdc090 Object (...), Mock_IUser_c8fdc090 Object (...)), array(array('Test', array(0, 'test0'))), array(array('Test One', array(0, 'test1')), array('Test Two', array(0, 'test2'))), false, false)
160	Error: Call to a member function getDisplayName() on string
161 162	/drone/src/lib/private/Collaboration/Collaborators/UserPlugin.php:101
163	/drone/src/tests/lib/Collaboration/Collaborators/UserPluginTest.php:458
164 165	6) Test\Collaboration\Collaborators\UserPluginTest::testSearch with data set #15 ('test', false, false, array(), array(Mock_IUser_c8fdc090 Object (...), Mock_IUser_c8fdc090 Object (...), Mock_IUser_c8fdc090 Object (...)), array(array('Test', array(0, 'test0'))), array(), true, false)
166	Error: Call to a member function getDisplayName() on string
167 168	/drone/src/lib/private/Collaboration/Collaborators/UserPlugin.php:101
169	/drone/src/tests/lib/Collaboration/Collaborators/UserPluginTest.php:458

[wiswedel]

doesn't work for me with 18.0.4. Sharee search field keeps spinning forever, even if matching email address is entered. Now not even guest invitation gets offered.

[wiswedel]

in 19 beta however it works. But we need the backport to work as well.

[skjnldsv]

doesn't work for me with 18.0.4. Sharee search field keeps spinning forever, even if matching email address is entered. Now not even guest invitation gets offered.

This pr is for 18.0.5 🤔

[wiswedel]

So what now? Can this be patched into an 18.0.3 or 18.0.4, or are there other dependencies coming with 18.0.5 only? Customer is waiting.

[skjnldsv]

@icewind1991 ?
edit: Rebased in the meantime

[MorrisJobke]

CI fails

[icewind1991]

Ci is happy