Skip to content

Fix Sharing recommendation user display - #20575

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/sharing-suggestions
Apr 22, 2020
Merged

Fix Sharing recommendation user display#20575
MorrisJobke merged 1 commit into
masterfrom
fix/sharing-suggestions

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Apr 21, 2020

Copy link
Copy Markdown
Member
  • Fix deprecated uses
  • Fix avatar display
    BeforeAfter
    Capture d’écran_2020-04-21_09-39-16Capture d’écran_2020-04-21_09-38-56

Found while digging on #20359

@skjnldsvskjnldsv added bug 3. to review Waiting for reviews feature: sharing feature: file sidebar Related to the file sidebar component labels Apr 21, 2020
@skjnldsvskjnldsv added this to the Nextcloud 19 milestone Apr 21, 2020
@skjnldsvskjnldsv self-assigned this Apr 21, 2020
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@rullzerrullzer mentioned this pull request Apr 21, 2020
55 tasks

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍

@MorrisJobke
MorrisJobke merged commit f0ad46d into masterApr 22, 2020
@MorrisJobke
MorrisJobke deleted the fix/sharing-suggestions branch April 22, 2020 12:56
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable18 in #20596 with conflicts ⚠️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: file sidebarRelated to the file sidebar componentfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@juliusknorr