Skip to content

Use a better error message and point the users to the support channels - #2058

Merged
MorrisJobke merged 2 commits into
masterfrom
better-error-message-for-installation-error
Nov 9, 2016
Merged

Use a better error message and point the users to the support channels#2058
MorrisJobke merged 2 commits into
masterfrom
better-error-message-for-installation-error

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Close#1956

@schiessle@karlitschek@MorrisJobke as discussed

should backport this until 9

Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

Copy link
Copy Markdown

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @LukasReschke and @icewind1991 to be potential reviewers.

@karlitschek

Copy link
Copy Markdown
Member

please backport

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
nickvergessenforce-pushed the better-error-message-for-installation-error branch from 4820fff to 2f7e291CompareNovember 9, 2016 09:30
@schiessle

Copy link
Copy Markdown
Member

looks good 👍

@codecov-io

Copy link
Copy Markdown

Current coverage is 57.75% (diff: 0.00%)

Merging #2058 into master will decrease coverage by <.01%

@@ master #2058 diff @@
==========================================
Files 1096 1096 Lines 62915 62928 +13 Methods 7015 7015 Messages 0 0 Branches 0 0 ==========================================
+ Hits 36344 36347 +3 - Misses 26571 26581 +10 
Partials 0 0 
Diff CoverageFile Path
0%lib/private/Updater.php
0%lib/private/Installer.php

Powered by Codecov. Last update 05cf1da...2f7e291

@schiessle

schiessle commented Nov 9, 2016

Copy link
Copy Markdown
Member

"The class Doctrine\DBAL\Exception\TableExistsException does not exist. Did you forget a USE statement, or did you not list all dependencies?"

https://scrutinizer-ci.com/g/nextcloud/server/inspections/c293ed04-8094-4510-8124-b8c2fa1f1387/issues/files/lib/private/Installer.php?status=new&orderField=path&order=asc&honorSelectedPaths=0

@nickvergessen

Copy link
Copy Markdown
MemberAuthor

Scrutinizer doesn't grab 3rdparty ;)

@MorrisJobke

Copy link
Copy Markdown
Member

👍

@MorrisJobke
MorrisJobke merged commit 742c215 into masterNov 9, 2016
@MorrisJobke
MorrisJobke deleted the better-error-message-for-installation-error branch November 9, 2016 12:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen@mention-bot@karlitschek@schiessle@codecov-io@MorrisJobke