Uh oh!
There was an error while loading. Please reload this page.
[stable18] Set fileInfo correctly for LegacyTabs - #20588
Merged
Merged
Conversation
backportbot-nextcloudBot
requested review from
ChristophWurst, MorrisJobke, go2sh, juliusknorr and skjnldsvApril 21, 2020 12:54
skjnldsv
commented
Apr 21, 2020
Member
/compile amend / |
skjnldsv
approved these changes
Apr 21, 2020
Watch for changes of the fileInfo prop and propagate it to, the underlying component. Fixes#20106. Signed-off-by: Christoph Seitz <christoph.seitz@posteo.de> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
backport/20564/stable18
branch
from
April 21, 2020 13:04
8313bbb to
185f867Comparego2sh
approved these changes
Apr 21, 2020
juliusknorr
approved these changes
Apr 21, 2020
kesselb
commented
Jun 6, 2020
Contributor
Seems to break the sidebar for activity and comments: #21239 |
go2sh
commented
Jun 6, 2020
Contributor
I'll check it tonight. |
go2sh
commented
Jun 6, 2020
Contributor
@kesselb I depends. ^^ This commit fixed some stuff with the reactivity of the tabs enabling the watching of the |
go2sh
commented
Jun 7, 2020
Contributor
So I see two possible fixes: 1) Revert this and set the fileInfo when opening the sidebar. (like the views) 2) Backport the reactivity fixes into the old nextcloud-vue branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #20564