Uh oh!
There was an error while loading. Please reload this page.
Fix IE11 upload fallback methods - #20595
Merged
Merged
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
requested review from
ChristophWurst, MorrisJobke, danxuliu, juliusknorr and rullzerApril 22, 2020 11:41
skjnldsv
commented
Apr 22, 2020
MemberAuthor
/backport to stable18 |
skjnldsv
commented
Apr 22, 2020
MemberAuthor
/backport to stable17 |
skjnldsv
commented
Apr 22, 2020
MemberAuthor
/backport to stable16 |
nickvergessen
commented
Apr 22, 2020
Member
@ma12-co do we need this in talk too? |
skjnldsv
commented
Apr 22, 2020
MemberAuthor
Now I'm afraid to look at the code you're using in talk 🙈 |
juliusknorr
approved these changes
Apr 22, 2020
danxuliu
approved these changes
Apr 22, 2020
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍
However, note that the problem was not in files without extension, but in files without extension, with size divisible by 4096 and smaller than 102400 bytes. How did you find this? xD
skjnldsv
commented
Apr 22, 2020
MemberAuthor
I have my reasons xD |
backport to stable18 in #20602 |
backport to stable17 in #20603 |
backport to stable16 in #20604 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
😡
https://developer.mozilla.org/en-US/docs/Web/API/FileReader/readAsBinaryString#Browser_compatibility
Steps: