Uh oh!
There was an error while loading. Please reload this page.
Don't load text file preview when text app is available (Fixes: #20615) - #20629
Merged
Conversation
mejo-force-pushed
the
files_sharing_preview_text
branch
from
April 24, 2020 09:02
d2437e5 to
9d23736CompareUh oh!
There was an error while loading. Please reload this page.
…loud#20615) When opening a shared text document, the files_sharing app uses internal preview support in case no other app to open the text file is available. So far, it only checks for the old files_texteditor app, not for the new new text app. This commit fixes this by checking for both. Signed-off-by: Jonas Meurer <jonas@freesources.org>
mejo-force-pushed
the
files_sharing_preview_text
branch
from
April 24, 2020 09:14
9d23736 to
afeeb1eComparegary-kim
commented
May 7, 2020
Member
/backport to stable18 |
kesselb
approved these changes
May 7, 2020
skjnldsv
approved these changes
May 8, 2020
georgehrke
approved these changes
May 8, 2020
juliusknorr
approved these changes
May 15, 2020
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
rullzer
commented
May 18, 2020
Member
/backport to stable19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a shared text document, the files_sharing app uses
internal preview support in case no other app to open the text file is
available.
So far, it only checks for the old files_texteditor app, not for the new
new text app. This commit fixes this by checking for both.