Skip to content

Add a wrapper to fall back to the share owner on public shares - #20718

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/public_share_owner_activity_mess
Apr 30, 2020
Merged

Add a wrapper to fall back to the share owner on public shares#20718
MorrisJobke merged 1 commit into
masterfrom
fix/public_share_owner_activity_mess

Conversation

@rullzer

@rullzerrullzer commented Apr 29, 2020

Copy link
Copy Markdown
Member

Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).

It is basicallyt a fall back since the public webdav endpoint is so unauthenticated.

  1. create a local external storage
  2. share it with edit rights
  3. open link
  4. Upload a file
  5. delte a file

before: boom
after: no boom

@rullzerrullzer added bug 3. to review Waiting for reviews labels Apr 29, 2020
@rullzerrullzer added this to the Nextcloud 19 milestone Apr 29, 2020
@rullzerrullzer mentioned this pull request Apr 29, 2020
Merged
11 tasks
@rullzer
Add a wrapper to fall back to the share owner on public shares
bc66bdc
Else it might happen that we setup a storage that has no real owner and
activities do boom etc (looking at you groupfolders and external
storages!).
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the fix/public_share_owner_activity_mess branch from a6fbcf6 to bc66bdcCompareApril 30, 2020 06:57
ChristophWurst
ChristophWurst approved these changes Apr 30, 2020
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works

MorrisJobke
MorrisJobke approved these changes Apr 30, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 0f9b88c into masterApr 30, 2020
@MorrisJobke
MorrisJobke deleted the fix/public_share_owner_activity_mess branch April 30, 2020 11:46
@MorrisJobke

MorrisJobke commented Apr 30, 2020

Copy link
Copy Markdown
Member

@rullzer Backport?

@rullzer

rullzer commented Apr 30, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@rullzer

rullzer commented Apr 30, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 30, 2020
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 30, 2020
Merged
@rullzerrullzer mentioned this pull request May 1, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@icewind1991icewind1991Awaiting requested review from icewind1991
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@ChristophWurst